From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751574Ab1HKOR0 (ORCPT ); Thu, 11 Aug 2011 10:17:26 -0400 Received: from cavan.codon.org.uk ([93.93.128.6]:37506 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751261Ab1HKORZ (ORCPT ); Thu, 11 Aug 2011 10:17:25 -0400 Date: Thu, 11 Aug 2011 15:16:30 +0100 From: Matthew Garrett To: Ali Gholami Rudi Cc: Andrew Morton , Keith Packard , Michel Alexandre Salim , intel-gfx@lists.freedesktop.org, Ali Gholami Rudi , Richard Purdie , Chris Wilson , David Airlie , Alex Deucher , Ben Skeggs , Zhang Rui , Len Brown , Jesse Barnes , Sedat Dilek , Linus Torvalds , linux-kernel@vger.kernel.org Subject: Re: missing acpi backlight bisected to 9661e92c10 Message-ID: <20110811141630.GA24704@srcf.ucam.org> References: <20110808213140.GA32504@srcf.ucam.org> <4E428421.1000605@fedoraproject.org> <20110810191700.81c3a7ee.akpm@linux-foundation.org> <20112108083014@lilem.mirepesht> <20112108160718@lilem.mirepesht> <20110811123929.GA22409@srcf.ucam.org> <20112108181410@lilem.mirepesht> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20112108181410@lilem.mirepesht> User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Well, that all looks fine. And I also can't see any way that this commit could cause the backlight not to appear - all it does is set the parent if it's present. There's no new path that could cause it to return early. Does reverting this patch really make things work? -- Matthew Garrett | mjg59@srcf.ucam.org