From: "Maxin B. John" <maxin.john@gmail.com>
To: rdunlap@xenotime.net
Cc: Boaz Harrosh <bharrosh@panasas.com>,
Benny Halevy <bhalevy@panasas.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
osd-dev@open-osd.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library
Date: Thu, 11 Aug 2011 17:27:50 +0300 [thread overview]
Message-ID: <20110811142749.GA26109@maxin> (raw)
SCSI_OSD_INITIATOR should select CRYPTO_SHA1 and CRYPTO_HMAC. Express this
in Kconfig so that the requirements are met automatically.
Signed-off-by: Maxin B. John <maxin.john@gmail.com>
---
diff --git a/drivers/scsi/osd/Kconfig b/drivers/scsi/osd/Kconfig
index 861b5ce..1535fe1 100644
--- a/drivers/scsi/osd/Kconfig
+++ b/drivers/scsi/osd/Kconfig
@@ -11,17 +11,16 @@
# it under the terms of the GNU General Public version 2 License as
# published by the Free Software Foundation
#
-# FIXME: SCSI_OSD_INITIATOR should select CONFIG (HMAC) SHA1 somehow.
-# How is it done properly?
#
config SCSI_OSD_INITIATOR
tristate "OSD-Initiator library"
depends on SCSI
+ select CRYPTO
+ select CRYPTO_SHA1
+ select CRYPTO_HMAC
help
Enable the OSD-Initiator library (libosd.ko).
- NOTE: You must also select CRYPTO_SHA1 + CRYPTO_HMAC and their
- dependencies
config SCSI_OSD_ULD
tristate "OSD Upper Level driver"
next reply other threads:[~2011-08-11 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 14:27 Maxin B. John [this message]
2011-08-14 23:18 ` [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library Maxin B John
2011-08-15 18:44 ` Boaz Harrosh
2011-08-25 13:10 ` Maxin B John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110811142749.GA26109@maxin \
--to=maxin.john@gmail.com \
--cc=JBottomley@parallels.com \
--cc=bhalevy@panasas.com \
--cc=bharrosh@panasas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=osd-dev@open-osd.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox