[PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library

[PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library

[Maxin B. John]

SCSI_OSD_INITIATOR should select CRYPTO_SHA1 and CRYPTO_HMAC. Express this
in Kconfig so that the requirements are met automatically. 

Signed-off-by: Maxin B. John <maxin.john@gmail.com>
---
diff --git a/drivers/scsi/osd/Kconfig b/drivers/scsi/osd/Kconfig
index 861b5ce..1535fe1 100644
--- a/drivers/scsi/osd/Kconfig
+++ b/drivers/scsi/osd/Kconfig
@@ -11,17 +11,16 @@
 # it under the terms of the GNU General Public version 2 License as
 # published by the Free Software Foundation
 #
-# FIXME: SCSI_OSD_INITIATOR should select CONFIG (HMAC) SHA1 somehow.
-#        How is it done properly?
 #
 
 config SCSI_OSD_INITIATOR
 	tristate "OSD-Initiator library"
 	depends on SCSI
+	select CRYPTO
+	select CRYPTO_SHA1
+	select CRYPTO_HMAC
 	help
 		Enable the OSD-Initiator library (libosd.ko).
-		NOTE: You must also select CRYPTO_SHA1 + CRYPTO_HMAC and their
-		dependencies
 
 config SCSI_OSD_ULD
 	tristate "OSD Upper Level driver"

Re: [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library

[Maxin B John]

Ping..

On Thu, Aug 11, 2011 at 5:27 PM, Maxin B. John <maxin.john@gmail.com> wrote:
> SCSI_OSD_INITIATOR should select CRYPTO_SHA1 and CRYPTO_HMAC. Express this
> in Kconfig so that the requirements are met automatically.
>
> Signed-off-by: Maxin B. John <maxin.john@gmail.com>
> ---
> diff --git a/drivers/scsi/osd/Kconfig b/drivers/scsi/osd/Kconfig
> index 861b5ce..1535fe1 100644
> --- a/drivers/scsi/osd/Kconfig
> +++ b/drivers/scsi/osd/Kconfig
> @@ -11,17 +11,16 @@
>  # it under the terms of the GNU General Public version 2 License as
>  # published by the Free Software Foundation
>  #
> -# FIXME: SCSI_OSD_INITIATOR should select CONFIG (HMAC) SHA1 somehow.
> -#        How is it done properly?
>  #
>
>  config SCSI_OSD_INITIATOR
>        tristate "OSD-Initiator library"
>        depends on SCSI
> +       select CRYPTO
> +       select CRYPTO_SHA1
> +       select CRYPTO_HMAC
>        help
>                Enable the OSD-Initiator library (libosd.ko).
> -               NOTE: You must also select CRYPTO_SHA1 + CRYPTO_HMAC and their
> -               dependencies
>
>  config SCSI_OSD_ULD
>        tristate "OSD Upper Level driver"
>

Re: [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library

[Boaz Harrosh]

On 08/14/2011 04:18 PM, Maxin B John wrote:
> Ping..
> 
> On Thu, Aug 11, 2011 at 5:27 PM, Maxin B. John <maxin.john@gmail.com> wrote:
>> SCSI_OSD_INITIATOR should select CRYPTO_SHA1 and CRYPTO_HMAC. Express this
>> in Kconfig so that the requirements are met automatically.
>>
>> Signed-off-by: Maxin B. John <maxin.john@gmail.com>

Yes sorry. It was on my todo and I never got to it.

OK So actually current osd_initiator code does not use these libraries.
It should, and I have very old code that started on that (hence the comment),
but it was never submitted to Kernel. The OSD protocol calls for all kind of
security levels that use these, but the current code only supports NO_SEC.

I will keep your patch for when security code goes in. Meanwhile I should
at least remove the stale comment.

Thanks
Boaz

>> ---
>> diff --git a/drivers/scsi/osd/Kconfig b/drivers/scsi/osd/Kconfig
>> index 861b5ce..1535fe1 100644
>> --- a/drivers/scsi/osd/Kconfig
>> +++ b/drivers/scsi/osd/Kconfig
>> @@ -11,17 +11,16 @@
>>  # it under the terms of the GNU General Public version 2 License as
>>  # published by the Free Software Foundation
>>  #
>> -# FIXME: SCSI_OSD_INITIATOR should select CONFIG (HMAC) SHA1 somehow.
>> -#        How is it done properly?
>>  #
>>
>>  config SCSI_OSD_INITIATOR
>>        tristate "OSD-Initiator library"
>>        depends on SCSI
>> +       select CRYPTO
>> +       select CRYPTO_SHA1
>> +       select CRYPTO_HMAC
>>        help
>>                Enable the OSD-Initiator library (libosd.ko).
>> -               NOTE: You must also select CRYPTO_SHA1 + CRYPTO_HMAC and their
>> -               dependencies
>>
>>  config SCSI_OSD_ULD
>>        tristate "OSD Upper Level driver"
>>

Re: [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library

[Maxin B John]

Hi,

On Mon, Aug 15, 2011 at 9:44 PM, Boaz Harrosh <bharrosh@panasas.com> wrote:
> On 08/14/2011 04:18 PM, Maxin B John wrote:
>> On Thu, Aug 11, 2011 at 5:27 PM, Maxin B. John <maxin.john@gmail.com> wrote:
>>> SCSI_OSD_INITIATOR should select CRYPTO_SHA1 and CRYPTO_HMAC. Express this
>>> in Kconfig so that the requirements are met automatically.
>>>
>>> Signed-off-by: Maxin B. John <maxin.john@gmail.com>
>
> OK So actually current osd_initiator code does not use these libraries.
> It should, and I have very old code that started on that (hence the comment),
> but it was never submitted to Kernel. The OSD protocol calls for all kind of
> security levels that use these, but the current code only supports NO_SEC.
>
> I will keep your patch for when security code goes in. Meanwhile I should
> at least remove the stale comment.

Sorry for the delay in reply. Yes, this makes perfect sense to me.

Cheers,
Maxin