* [PATCH 1/1] misc/pti.c: Fix build error when PCI is not selected
@ 2011-08-11 16:23 Tracey Dent
2011-08-11 16:45 ` Randy Dunlap
0 siblings, 1 reply; 8+ messages in thread
From: Tracey Dent @ 2011-08-11 16:23 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, gregkh, tdent48227
When you try to build INTEL_MID_PTI without having PCI
enabled. It fails like this-
CC [M] drivers/misc/pti.o
drivers/misc/pti.c: In function ‘pti_pci_remove’:
drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’
drivers/misc/pti.c: In function ‘pti_pci_probe’:
drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’
So make INTEL_MID_PTI depend on PCI to fix build error.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
drivers/misc/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 0a4d86c..2d6423c 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -146,6 +146,7 @@ config PHANTOM
config INTEL_MID_PTI
tristate "Parallel Trace Interface for MIPI P1149.7 cJTAG standard"
+ depends on PCI
default n
help
The PTI (Parallel Trace Interface) driver directs
--
1.7.6.433.g1421f
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] misc/pti.c: Fix build error when PCI is not selected
2011-08-11 16:23 [PATCH 1/1] misc/pti.c: Fix build error when PCI is not selected Tracey Dent
@ 2011-08-11 16:45 ` Randy Dunlap
2011-08-11 16:56 ` Greg KH
2011-08-11 16:59 ` Tracey Dent
0 siblings, 2 replies; 8+ messages in thread
From: Randy Dunlap @ 2011-08-11 16:45 UTC (permalink / raw)
To: Tracey Dent; +Cc: linux-kernel, akpm, gregkh
On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote:
> When you try to build INTEL_MID_PTI without having PCI
> enabled. It fails like this-
>
> CC [M] drivers/misc/pti.o
> drivers/misc/pti.c: In function ‘pti_pci_remove’:
> drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’
> drivers/misc/pti.c: In function ‘pti_pci_probe’:
> drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’
>
> So make INTEL_MID_PTI depend on PCI to fix build error.
I think (hope) that Greg already has a patch like this queued.
Greg- are you planning to push some patches soon?
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
> drivers/misc/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 0a4d86c..2d6423c 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -146,6 +146,7 @@ config PHANTOM
>
> config INTEL_MID_PTI
> tristate "Parallel Trace Interface for MIPI P1149.7 cJTAG standard"
> + depends on PCI
> default n
> help
> The PTI (Parallel Trace Interface) driver directs
> --
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] misc/pti.c: Fix build error when PCI is not selected
2011-08-11 16:45 ` Randy Dunlap
@ 2011-08-11 16:56 ` Greg KH
2011-08-11 16:59 ` Tracey Dent
1 sibling, 0 replies; 8+ messages in thread
From: Greg KH @ 2011-08-11 16:56 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Tracey Dent, linux-kernel, akpm
On Thu, Aug 11, 2011 at 09:45:20AM -0700, Randy Dunlap wrote:
> On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote:
>
> > When you try to build INTEL_MID_PTI without having PCI
> > enabled. It fails like this-
> >
> > CC [M] drivers/misc/pti.o
> > drivers/misc/pti.c: In function ‘pti_pci_remove’:
> > drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’
> > drivers/misc/pti.c: In function ‘pti_pci_probe’:
> > drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’
> >
> > So make INTEL_MID_PTI depend on PCI to fix build error.
>
> I think (hope) that Greg already has a patch like this queued.
> Greg- are you planning to push some patches soon?
Yes, sorry, "real work" has been keeping me really busy at the moment,
I'll get to pushing these to Linus soon.
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] misc/pti.c: Fix build error when PCI is not selected
2011-08-11 16:45 ` Randy Dunlap
2011-08-11 16:56 ` Greg KH
@ 2011-08-11 16:59 ` Tracey Dent
2011-08-18 16:24 ` Ingo Molnar
1 sibling, 1 reply; 8+ messages in thread
From: Tracey Dent @ 2011-08-11 16:59 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, akpm, gregkh
On Thu, Aug 11, 2011 at 09:45:20AM -0700, Randy Dunlap wrote:
> On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote:
>
> > When you try to build INTEL_MID_PTI without having PCI
> > enabled. It fails like this-
> >
> > CC [M] drivers/misc/pti.o
> > drivers/misc/pti.c: In function ‘pti_pci_remove’:
> > drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’
> > drivers/misc/pti.c: In function ‘pti_pci_probe’:
> > drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’
> >
> > So make INTEL_MID_PTI depend on PCI to fix build error.
>
> I think (hope) that Greg already has a patch like this queued.
> Greg- are you planning to push some patches soon?
>
>
Okay, sorry for the noise then.
> > Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> > ---
> > drivers/misc/Kconfig | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> > index 0a4d86c..2d6423c 100644
> > --- a/drivers/misc/Kconfig
> > +++ b/drivers/misc/Kconfig
> > @@ -146,6 +146,7 @@ config PHANTOM
> >
> > config INTEL_MID_PTI
> > tristate "Parallel Trace Interface for MIPI P1149.7 cJTAG standard"
> > + depends on PCI
> > default n
> > help
> > The PTI (Parallel Trace Interface) driver directs
> > --
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
regards,
Tracey Dent
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] misc/pti.c: Fix build error when PCI is not selected
2011-08-11 16:59 ` Tracey Dent
@ 2011-08-18 16:24 ` Ingo Molnar
2011-08-18 18:39 ` Greg KH
0 siblings, 1 reply; 8+ messages in thread
From: Ingo Molnar @ 2011-08-18 16:24 UTC (permalink / raw)
To: Tracey Dent; +Cc: Randy Dunlap, linux-kernel, akpm, gregkh
* Tracey Dent <tdent48227@gmail.com> wrote:
> On Thu, Aug 11, 2011 at 09:45:20AM -0700, Randy Dunlap wrote:
> > On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote:
> >
> > > When you try to build INTEL_MID_PTI without having PCI
> > > enabled. It fails like this-
> > >
> > > CC [M] drivers/misc/pti.o
> > > drivers/misc/pti.c: In function ‘pti_pci_remove’:
> > > drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’
> > > drivers/misc/pti.c: In function ‘pti_pci_probe’:
> > > drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’
> > >
> > > So make INTEL_MID_PTI depend on PCI to fix build error.
> >
> > I think (hope) that Greg already has a patch like this queued.
> > Greg- are you planning to push some patches soon?
> >
> >
>
> Okay, sorry for the noise then.
FYI, The fix is still not upstream, as of today's -git
(72ed62bdc46d):
drivers/misc/pti.c:410:3: error: implicit declaration of function ‘pci_release_region’ [-Werror=implicit-function-declaration]
drivers/misc/pti.c:859:2: error: implicit declaration of function ‘pci_request_region’ [-Werror=implicit-function-declaration]
Thanks,
Ingo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] misc/pti.c: Fix build error when PCI is not selected
2011-08-18 16:24 ` Ingo Molnar
@ 2011-08-18 18:39 ` Greg KH
2011-08-18 20:29 ` Ingo Molnar
2011-08-19 18:52 ` Randy Dunlap
0 siblings, 2 replies; 8+ messages in thread
From: Greg KH @ 2011-08-18 18:39 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Tracey Dent, Randy Dunlap, linux-kernel, akpm
On Thu, Aug 18, 2011 at 06:24:19PM +0200, Ingo Molnar wrote:
>
> * Tracey Dent <tdent48227@gmail.com> wrote:
>
> > On Thu, Aug 11, 2011 at 09:45:20AM -0700, Randy Dunlap wrote:
> > > On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote:
> > >
> > > > When you try to build INTEL_MID_PTI without having PCI
> > > > enabled. It fails like this-
> > > >
> > > > CC [M] drivers/misc/pti.o
> > > > drivers/misc/pti.c: In function ‘pti_pci_remove’:
> > > > drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’
> > > > drivers/misc/pti.c: In function ‘pti_pci_probe’:
> > > > drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’
> > > >
> > > > So make INTEL_MID_PTI depend on PCI to fix build error.
> > >
> > > I think (hope) that Greg already has a patch like this queued.
> > > Greg- are you planning to push some patches soon?
> > >
> > >
> >
> > Okay, sorry for the noise then.
>
> FYI, The fix is still not upstream, as of today's -git
> (72ed62bdc46d):
>
> drivers/misc/pti.c:410:3: error: implicit declaration of function ‘pci_release_region’ [-Werror=implicit-function-declaration]
> drivers/misc/pti.c:859:2: error: implicit declaration of function ‘pci_request_region’ [-Werror=implicit-function-declaration]
Yes, sorry, stuck at LinuxCon this week, will get it to Linus next week.
He's busy as well, so it's not like he could pull while underwater
anyway :)
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] misc/pti.c: Fix build error when PCI is not selected
2011-08-18 18:39 ` Greg KH
@ 2011-08-18 20:29 ` Ingo Molnar
2011-08-19 18:52 ` Randy Dunlap
1 sibling, 0 replies; 8+ messages in thread
From: Ingo Molnar @ 2011-08-18 20:29 UTC (permalink / raw)
To: Greg KH; +Cc: Tracey Dent, Randy Dunlap, linux-kernel, akpm
* Greg KH <gregkh@suse.de> wrote:
> On Thu, Aug 18, 2011 at 06:24:19PM +0200, Ingo Molnar wrote:
> >
> > * Tracey Dent <tdent48227@gmail.com> wrote:
> >
> > > On Thu, Aug 11, 2011 at 09:45:20AM -0700, Randy Dunlap wrote:
> > > > On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote:
> > > >
> > > > > When you try to build INTEL_MID_PTI without having PCI
> > > > > enabled. It fails like this-
> > > > >
> > > > > CC [M] drivers/misc/pti.o
> > > > > drivers/misc/pti.c: In function ‘pti_pci_remove’:
> > > > > drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’
> > > > > drivers/misc/pti.c: In function ‘pti_pci_probe’:
> > > > > drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’
> > > > >
> > > > > So make INTEL_MID_PTI depend on PCI to fix build error.
> > > >
> > > > I think (hope) that Greg already has a patch like this queued.
> > > > Greg- are you planning to push some patches soon?
> > > >
> > > >
> > >
> > > Okay, sorry for the noise then.
> >
> > FYI, The fix is still not upstream, as of today's -git
> > (72ed62bdc46d):
> >
> > drivers/misc/pti.c:410:3: error: implicit declaration of function ‘pci_release_region’ [-Werror=implicit-function-declaration]
> > drivers/misc/pti.c:859:2: error: implicit declaration of function ‘pci_request_region’ [-Werror=implicit-function-declaration]
>
> Yes, sorry, stuck at LinuxCon this week, will get it to Linus next
> week. He's busy as well, so it's not like he could pull while
> underwater anyway :)
No rush: the failures trigger pretty rately - just wanted to make
sure it's not lost.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] misc/pti.c: Fix build error when PCI is not selected
2011-08-18 18:39 ` Greg KH
2011-08-18 20:29 ` Ingo Molnar
@ 2011-08-19 18:52 ` Randy Dunlap
1 sibling, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2011-08-19 18:52 UTC (permalink / raw)
To: Greg KH; +Cc: Ingo Molnar, Tracey Dent, linux-kernel, akpm
On Thu, 18 Aug 2011 11:39:39 -0700 Greg KH wrote:
> On Thu, Aug 18, 2011 at 06:24:19PM +0200, Ingo Molnar wrote:
> >
> > * Tracey Dent <tdent48227@gmail.com> wrote:
> >
> > > On Thu, Aug 11, 2011 at 09:45:20AM -0700, Randy Dunlap wrote:
> > > > On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote:
> > > >
> > > > > When you try to build INTEL_MID_PTI without having PCI
> > > > > enabled. It fails like this-
> > > > >
> > > > > CC [M] drivers/misc/pti.o
> > > > > drivers/misc/pti.c: In function ‘pti_pci_remove’:
> > > > > drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’
> > > > > drivers/misc/pti.c: In function ‘pti_pci_probe’:
> > > > > drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’
> > > > >
> > > > > So make INTEL_MID_PTI depend on PCI to fix build error.
> > > >
> > > > I think (hope) that Greg already has a patch like this queued.
> > > > Greg- are you planning to push some patches soon?
> > > >
> > > >
> > >
> > > Okay, sorry for the noise then.
> >
> > FYI, The fix is still not upstream, as of today's -git
> > (72ed62bdc46d):
> >
> > drivers/misc/pti.c:410:3: error: implicit declaration of function ‘pci_release_region’ [-Werror=implicit-function-declaration]
> > drivers/misc/pti.c:859:2: error: implicit declaration of function ‘pci_request_region’ [-Werror=implicit-function-declaration]
>
> Yes, sorry, stuck at LinuxCon this week, will get it to Linus next week.
> He's busy as well, so it's not like he could pull while underwater
> anyway :)
I guess he did merge patches somehow yesterday....
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-08-19 18:52 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-11 16:23 [PATCH 1/1] misc/pti.c: Fix build error when PCI is not selected Tracey Dent
2011-08-11 16:45 ` Randy Dunlap
2011-08-11 16:56 ` Greg KH
2011-08-11 16:59 ` Tracey Dent
2011-08-18 16:24 ` Ingo Molnar
2011-08-18 18:39 ` Greg KH
2011-08-18 20:29 ` Ingo Molnar
2011-08-19 18:52 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox