public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vasiliy Kulikov <segoon@openwall.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: NeilBrown <neilb@suse.de>,
	linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jiri Slaby <jslaby@suse.cz>, James Morris <jmorris@namei.org>,
	kernel-hardening@lists.openwall.com
Subject: Re: [kernel-hardening] Re: [PATCH v3 -resend] move RLIMIT_NPROC check from set_user() to do_execve_common()
Date: Thu, 11 Aug 2011 21:18:12 +0400	[thread overview]
Message-ID: <20110811171812.GA17346@albatros> (raw)
In-Reply-To: <20110809121632.18aef937@notabene.brown>

Hi Linus,

On Tue, Aug 09, 2011 at 12:16 +1000, NeilBrown wrote:
> On Mon, 8 Aug 2011 19:02:04 +0400 Vasiliy Kulikov <segoon@openwall.com> wrote:
> 
> > The patch http://lkml.org/lkml/2003/7/13/226 introduced an RLIMIT_NPROC
> > check in set_user() to check for NPROC exceeding via setuid() and
> > similar functions.  Before the check there was a possibility to greatly
> > exceed the allowed number of processes by an unprivileged user if the
> > program relied on rlimit only.  But the check created new security
> > threat: many poorly written programs simply don't check setuid() return
> > code and believe it cannot fail if executed with root privileges.  So,
> > the check is removed in this patch because of too often privilege
> > escalations related to buggy programs.
...
> > Reviewed-by: James Morris <jmorris@namei.org>
> Acked-by: NeilBrown <neilb@suse.de>

It got 2 positive feedbacks and seems nobody has better solution.
Is it possible to see it in 3.1?

Thanks!

-- 
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments

  reply	other threads:[~2011-08-11 17:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-08 15:02 [PATCH v3 -resend] move RLIMIT_NPROC check from set_user() to do_execve_common() Vasiliy Kulikov
2011-08-09  2:16 ` NeilBrown
2011-08-11 17:18   ` Vasiliy Kulikov [this message]
2011-08-11 18:27     ` [kernel-hardening] " Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110811171812.GA17346@albatros \
    --to=segoon@openwall.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=gregkh@suse.de \
    --cc=jmorris@namei.org \
    --cc=jslaby@suse.cz \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox