public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Stephen Warren <swarren@nvidia.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Colin Cross <ccross@android.com>,
	Erik Gilling <konkers@android.com>,
	Olof Johansson <olof@lixom.net>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: tegra: Fix <mach/gpio.h> to have necessary #includes
Date: Thu, 11 Aug 2011 21:02:10 +0100	[thread overview]
Message-ID: <20110811200210.GB24166@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF04AEA24CD0@HQMAIL01.nvidia.com>

On Thu, Aug 11, 2011 at 12:49:47PM -0700, Stephen Warren wrote:
> Russell King wrote at Thursday, August 11, 2011 1:36 PM:
> > On Thu, Aug 11, 2011 at 12:05:52PM -0600, Stephen Warren wrote:
> > > Without this, EINVAL isn't defined, and type bool isn't declared.
> > > This leads to compilation failures.
> > 
> > An alternative approach would be to convert tegra to be able to use
> > the gpiolib __gpio_to_irq() for the on-SoC stuff, and eliminate
> > irq_to_gpio().
> > 
> > Would it be possible to do that instead?
> 
> That should work too.
> 
> I posted a couple patches last Friday to remove irq_to_gpio:
> 
> https://lkml.org/lkml/2011/8/5/343
> https://lkml.org/lkml/2011/8/5/342
> 
> Later in the thread, you said you would merge them into your branch to
> avoid merge conflicts with the other GPIO work you were doing.

I suggested it would be a good idea.  Now that I've published those
changes, any chance of having some updated patches in the patch system
please?

> For gpio_to_irq, yes, I believe we get rid of it pretty easily; we'd
> just need to implement gpio-tegra.c's gpio_chip.to_irq function. Should
> I cook up a patch based on top of linux-next plus the two patches above
> to do that instead?

Yes please, again eventually to the patch system once Grant has acked it
to avoid the otherwise certain conflicts.

Thanks for doing this.

  reply	other threads:[~2011-08-11 20:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-11 19:49 [PATCH] ARM: tegra: Fix <mach/gpio.h> to have necessary #includes Stephen Warren
2011-08-11 20:02 ` Russell King - ARM Linux [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-08-11 18:05 Stephen Warren
2011-08-11 19:36 ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110811200210.GB24166@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=arnd@arndb.de \
    --cc=ccross@android.com \
    --cc=konkers@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox