From: Robert Richter <robert.richter@amd.com>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: "schwidefsky@de.ibm.com" <schwidefsky@de.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Julia Lawall <julia@diku.dk>,
Heinz Graalfs <graalfs@linux.vnet.ibm.com>
Subject: Re: Missing put_cpu() in arch/s390/oprofile/hwsampler.c?
Date: Thu, 11 Aug 2011 23:23:54 +0200 [thread overview]
Message-ID: <20110811212354.GD11702@erda.amd.com> (raw)
In-Reply-To: <1312825916.5589.150.camel@localhost.localdomain>
On 08.08.11 13:51:53, Thomas Meyer wrote:
> The function hws_oom_callback() seems to miss a corresponding put_cpu().
Yes, it looks broken.
Heinz, can you send a fix please?
Thanks,
-Robert
>
> Or is this done in another function? I didn't find it.
>
> thomas
>
> ---
>
> Check for get/put_cpu() imbalances
>
> The simplified semantic patch that makes this report is:
>
> * get_cpu()
> ... when != put_cpu()
> ? get_cpu()
>
> drivers/crypto/n2_core.c:986:25-26: WARNING: Possible missing put_cpu()!
> drivers/crypto/n2_core.c:1041:25-26: WARNING: Possible missing put_cpu()!
> drivers/scsi/fcoe/fcoe.c:1163:29-30: WARNING: Possible missing put_cpu()!
> drivers/scsi/fcoe/fcoe.c:1630:47-48: WARNING: Possible missing put_cpu()!
> arch/um/sys-i386/ldt.c:53:17-18: WARNING: Possible missing put_cpu()!
> arch/powerpc/kernel/machine_kexec_64.c:188:18-19: WARNING: Possible missing put_cpu()!
> arch/ia64/sn/kernel/sn2/sn_hwperf.c:618:52-53: WARNING: Possible missing put_cpu()!
> arch/s390/oprofile/hwsampler.c:553:16-17: WARNING: Possible missing put_cpu()!
> arch/s390/kernel/vtime.c:430:22-23: WARNING: Possible missing put_cpu()!
> arch/s390/kernel/vtime.c:473:15-16: WARNING: Possible missing put_cpu()!
> arch/blackfin/kernel/cplbinfo.c:89:9-10: WARNING: Possible missing put_cpu()!
>
> This list contains some false positives.
>
> Thanks to Julia for the semantic patch to find these kind of errors!
>
>
--
Advanced Micro Devices, Inc.
Operating System Research Center
prev parent reply other threads:[~2011-08-11 21:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 17:51 Missing put_cpu() in arch/s390/oprofile/hwsampler.c? Thomas Meyer
2011-08-11 21:23 ` Robert Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110811212354.GD11702@erda.amd.com \
--to=robert.richter@amd.com \
--cc=graalfs@linux.vnet.ibm.com \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox