[PATCH] staging: ft1000: fix build failure

[PATCH] staging: ft1000: fix build failure

[Sergei Trofimovich]

Found on allmodconfig build (ARCH=alpha)

    drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_read_reg':
    drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:80: error: implicit declaration of function 'inw'
    drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_write_reg':
    drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:86: error: implicit declaration of function 'outw'

Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Cc: Marek Belisko <marek.belisko@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Ondrej Zary <linux@rainbow-software.org>
Cc: devel@driverdev.osuosl.org
---
 drivers/staging/ft1000/ft1000-pcmcia/ft1000.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000.h b/drivers/staging/ft1000/ft1000-pcmcia/ft1000.h
index 3b0130f..c2f835f 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000.h
+++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000.h
@@ -19,6 +19,7 @@
 #ifndef _FT1000H_
 #define _FT1000H_
 
+#include <linux/io.h>
 #include "../ft1000.h"
 
 #define FT1000_DRV_VER 0x01010300
-- 
1.7.3.4

Re: [PATCH] staging: ft1000: fix build failure

[Greg KH]

On Sun, Aug 14, 2011 at 11:52:53PM +0300, Sergei Trofimovich wrote:
> Found on allmodconfig build (ARCH=alpha)
> 
>     drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_read_reg':
>     drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:80: error: implicit declaration of function 'inw'
>     drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_write_reg':
>     drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:86: error: implicit declaration of function 'outw'
> 
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> Cc: Marek Belisko <marek.belisko@gmail.com>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Cc: Ondrej Zary <linux@rainbow-software.org>
> Cc: devel@driverdev.osuosl.org
> ---
>  drivers/staging/ft1000/ft1000-pcmcia/ft1000.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

This, and your other patches, are all not necessary in Linus's tree
right now, right?  I thought I already sent them to him.

Or am I mistaken?

greg k-h

Re: [PATCH] staging: ft1000: fix build failure

[Sergei Trofimovich]

[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]

On Sun, 14 Aug 2011 15:23:51 -0700
Greg KH <gregkh@suse.de> wrote:

> On Sun, Aug 14, 2011 at 11:52:53PM +0300, Sergei Trofimovich wrote:
> > Found on allmodconfig build (ARCH=alpha)
> > 
> >     drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_read_reg':
> >     drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:80: error: implicit declaration of function 'inw'
> >     drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_write_reg':
> >     drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:86: error: implicit declaration of function 'outw'
> > 
> > Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> > Cc: Marek Belisko <marek.belisko@gmail.com>
> > Cc: Greg Kroah-Hartman <gregkh@suse.de>
> > Cc: Ondrej Zary <linux@rainbow-software.org>
> > Cc: devel@driverdev.osuosl.org
> > ---
> >  drivers/staging/ft1000/ft1000-pcmcia/ft1000.h |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> This, and your other patches, are all not necessary in Linus's tree
> right now, right?  I thought I already sent them to him.
> 
> Or am I mistaken?

Oh, some of them really are. My apologies!
Only the one (nonstaging one) is still needed:

    'pti: fix build failure'

Thanks!

-- 

  Sergei

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] staging: ft1000: fix build failure

[Greg KH]

On Mon, Aug 15, 2011 at 06:18:33AM +0300, Sergei Trofimovich wrote:
> On Sun, 14 Aug 2011 15:23:51 -0700
> Greg KH <gregkh@suse.de> wrote:
> 
> > On Sun, Aug 14, 2011 at 11:52:53PM +0300, Sergei Trofimovich wrote:
> > > Found on allmodconfig build (ARCH=alpha)
> > > 
> > >     drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_read_reg':
> > >     drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:80: error: implicit declaration of function 'inw'
> > >     drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_write_reg':
> > >     drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:86: error: implicit declaration of function 'outw'
> > > 
> > > Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> > > Cc: Marek Belisko <marek.belisko@gmail.com>
> > > Cc: Greg Kroah-Hartman <gregkh@suse.de>
> > > Cc: Ondrej Zary <linux@rainbow-software.org>
> > > Cc: devel@driverdev.osuosl.org
> > > ---
> > >  drivers/staging/ft1000/ft1000-pcmcia/ft1000.h |    1 +
> > >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > This, and your other patches, are all not necessary in Linus's tree
> > right now, right?  I thought I already sent them to him.
> > 
> > Or am I mistaken?
> 
> Oh, some of them really are. My apologies!
> Only the one (nonstaging one) is still needed:
> 
>     'pti: fix build failure'

Yes, I still have that queued up in my todo inbox somewhere, thanks.

greg k-h