From: Johan Hovold <jhovold@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@ti.com>, Liam Girdwood <lrg@slimlogic.co.uk>,
Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH 2/3] regulator: tps65910: fix list_voltage for VDD1 and VDD2
Date: Mon, 15 Aug 2011 17:12:53 +0200 [thread overview]
Message-ID: <20110815151253.GC4189@localhost> (raw)
In-Reply-To: <20110815144910.GA29685@opensource.wolfsonmicro.com>
On Mon, Aug 15, 2011 at 11:49:13PM +0900, Mark Brown wrote:
> On Mon, Aug 15, 2011 at 04:29:48PM +0200, Johan Hovold wrote:
> > On Mon, Aug 15, 2011 at 10:09:13PM +0900, Mark Brown wrote:
>
> > > Why is this a separate patch to the previous one?
>
> > Because it fixes a different bug (although introduced by the same commit
> > and the same kind of programming error).
>
> You've got a bunch of missing break statements introduced by the same
> commit in the same driver causing the same runtime issue...
Well, the first bug prevents any device from being used at all (as probe
always fails). The second bug makes list_voltage return the wrong value
for two regulators.
I simply prefer fixing them separately as it will be more clear from the
changelog what behaviours are being fixed -- especially as they are
marked for stable.
Thanks,
Johan
next prev parent reply other threads:[~2011-08-15 15:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 10:45 [PATCH 1/3] regulator: tps65910: fix device initialisation Johan Hovold
2011-08-15 10:45 ` [PATCH 2/3] regulator: tps65910: fix list_voltage for VDD1 and VDD2 Johan Hovold
2011-08-15 13:09 ` Mark Brown
2011-08-15 14:29 ` Johan Hovold
2011-08-15 14:49 ` Mark Brown
2011-08-15 15:12 ` Johan Hovold [this message]
2011-08-15 15:39 ` Mark Brown
2011-08-15 10:45 ` [PATCH 3/3] regulator: tps65910: verify dcdc regulator ids Johan Hovold
2011-08-15 13:10 ` Mark Brown
2011-08-30 16:07 ` [PATCH 3/3 v2] " Johan Hovold
2011-08-30 16:07 ` Mark Brown
2011-08-31 13:26 ` Liam Girdwood
2011-08-15 13:08 ` [PATCH 1/3] regulator: tps65910: fix device initialisation Mark Brown
2011-08-28 16:32 ` Liam Girdwood
2011-08-30 16:05 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110815151253.GC4189@localhost \
--to=jhovold@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jedu@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox