[PATCH 3/3] regulator: tps65910: verify dcdc regulator ids

Johan Hovold
2011-08-15T10:45:48Z

Add default case to switches in dcdc voltage functions.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
---
drivers/regulator/tps65910-regulator.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c
index 2c61e48..991dfa4 100644
--- a/drivers/regulator/tps65910-regulator.c
+++ b/drivers/regulator/tps65910-regulator.c
@@ -534,6 +534,8 @@ static int tps65910_get_voltage_dcdc(struct regulator_dev *dev)
srvsel &= VDDCTRL_SR_SEL_MASK;
vselmax = 64;
break;
+ default:
+ return -EINVAL;
}

/* multiplier 0 == 1 but 2,3 normal */
@@ -688,6 +690,9 @@ static int tps65910_set_voltage_dcdc(struct regulator_dev *dev,
case TPS65911_REG_VDDCTRL:
vsel = selector;
tps65910_reg_write(pmic, TPS65911_VDDCTRL_OP, vsel);
+ break;
+ default:
+ return -EINVAL;
}

return 0;
@@ -762,6 +767,9 @@ static int tps65910_list_voltage_dcdc(struct regulator_dev *dev,
break;
case TPS65911_REG_VDDCTRL:
volt = VDDCTRL_MIN_VOLT + (selector * VDDCTRL_OFFSET);
+ break;
+ default:
+ return -EINVAL;
}

return volt * 100 * mult;
--
1.7.6