Re: [PATCH 2/3] regulator: tps65910: fix list_voltage for VDD1 and VDD2

Mark Brown
2011-08-15T15:39:19Z

On Mon, Aug 15, 2011 at 05:12:53PM +0200, Johan Hovold wrote:
> On Mon, Aug 15, 2011 at 11:49:13PM +0900, Mark Brown wrote:

> > You've got a bunch of missing break statements introduced by the same
> > commit in the same driver causing the same runtime issue...

> Well, the first bug prevents any device from being used at all (as probe
> always fails). The second bug makes list_voltage return the wrong value
> for two regulators.

> I simply prefer fixing them separately as it will be more clear from the
> changelog what behaviours are being fixed -- especially as they are
> marked for stable.

As a reviewer I did a double take as I wasn't immediately sure if this
was actually a different patch or not.