From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Cc: trivial@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/10]include:linux Remove pointless "@" from various parts of the kernel
Date: Mon, 15 Aug 2011 08:51:01 -0700 [thread overview]
Message-ID: <20110815155101.GJ2389@linux.vnet.ibm.com> (raw)
In-Reply-To: <1313195235-4522-10-git-send-email-justinmattock@gmail.com>
On Fri, Aug 12, 2011 at 05:27:15PM -0700, Justin P. Mattock wrote:
> From: "Justin P. Mattock" <justinmattock@gmail.com>
>
> The patch series below removes some pointless "@"'s in various parts of the kernel.
> Note: some might be useful, but then again, some just seemed a waste of space.
> (and since the kernel is become bloated, might as well diet! even if it's a few bits)
I would like to keep the RCU "@@@", please!
Thanx, Paul
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
>
> ---
> include/linux/jbd.h | 2 +-
> include/linux/jbd2.h | 2 +-
> include/linux/rcupdate.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/jbd.h b/include/linux/jbd.h
> index e6a5e34..7f3b109 100644
> --- a/include/linux/jbd.h
> +++ b/include/linux/jbd.h
> @@ -273,7 +273,7 @@ typedef struct journal_superblock_s
> enum jbd_state_bits {
> BH_JBD /* Has an attached ext3 journal_head */
> = BH_PrivateStart,
> - BH_JWrite, /* Being written to log (@@@ DEBUGGING) */
> + BH_JWrite, /* Being written to log DEBUGGING */
> BH_Freed, /* Has been freed (truncated) */
> BH_Revoked, /* Has been revoked from the log */
> BH_RevokeValid, /* Revoked flag is valid */
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index 38f307b..4a7ad4b 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -305,7 +305,7 @@ typedef struct journal_superblock_s
> enum jbd_state_bits {
> BH_JBD /* Has an attached ext3 journal_head */
> = BH_PrivateStart,
> - BH_JWrite, /* Being written to log (@@@ DEBUGGING) */
> + BH_JWrite, /* Being written to log DEBUGGING */
> BH_Freed, /* Has been freed (truncated) */
> BH_Revoked, /* Has been revoked from the log */
> BH_RevokeValid, /* Revoked flag is valid */
> diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
> index 8f4f881..cfb5d7b 100644
> --- a/include/linux/rcupdate.h
> +++ b/include/linux/rcupdate.h
> @@ -443,7 +443,7 @@ extern int rcu_my_thread_group_empty(void);
> __rcu_dereference_check((p), rcu_read_lock_sched_held() || (c), \
> __rcu)
>
> -#define rcu_dereference_raw(p) rcu_dereference_check(p, 1) /*@@@ needed? @@@*/
> +#define rcu_dereference_raw(p) rcu_dereference_check(p, 1) /* needed? */
>
> /**
> * rcu_access_index() - fetch RCU index with no dereferencing
> --
> 1.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2011-08-15 15:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-13 0:27 [PATCH 01/10]arch:mips:sibyte:sb1250:setup.c Remove pointless "@" from various parts of the kernel Justin P. Mattock
2011-08-13 0:27 ` [PATCH 02/10]arch:powerpc:kernel:rtasd.c " Justin P. Mattock
2011-08-13 0:27 ` [PATCH 03/10]Documentation:usb:linux.inf " Justin P. Mattock
2011-08-13 0:27 ` [PATCH 04/10]drivers:atm " Justin P. Mattock
2011-08-13 6:22 ` David Miller
2011-08-13 0:27 ` [PATCH 05/10]drivers:media " Justin P. Mattock
2011-08-13 0:27 ` [PATCH 06/10]drivers:staging " Justin P. Mattock
2011-08-13 0:27 ` [PATCH 07/10]drivers:net " Justin P. Mattock
2011-08-13 0:27 ` [PATCH 08/10]fs " Justin P. Mattock
2011-08-13 0:27 ` [PATCH 09/10]net " Justin P. Mattock
2011-08-13 0:27 ` [PATCH 10/10]include:linux " Justin P. Mattock
2011-08-15 15:51 ` Paul E. McKenney [this message]
2011-08-15 16:40 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110815155101.GJ2389@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=justinmattock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox