[PATCH] regmap: using module facilities requires module.h

[PATCH] regmap: using module facilities requires module.h

[Stephen Rothwell]

Commit b33f9cbd67ba ("regmap: Specify a module license") added a
MODULES_LICENSE to this file without adding an include of module.h.
module.h should ahve been included anyway, since this file has
EXPORT_SYMBOLs as well.   With the pending module.h spliit up, this would
probably caused build problems.

Cc: Stephen Warren <swarren@nvidia.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/base/regmap/regmap-spi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

I am sorry that I have not even build tested this patch, but it is pretty
obvious.

diff --git a/drivers/base/regmap/regmap-spi.c b/drivers/base/regmap/regmap-spi.c
index 2bbc659..f839694 100644
--- a/drivers/base/regmap/regmap-spi.c
+++ b/drivers/base/regmap/regmap-spi.c
@@ -13,6 +13,7 @@
 #include <linux/regmap.h>
 #include <linux/spi/spi.h>
 #include <linux/init.h>
+#include <linux/module.h>
 
 static int regmap_spi_write(struct device *dev, const void *data, size_t count)
 {
-- 
1.7.5.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: [PATCH] regmap: using module facilities requires module.h

[Mark Brown]

On Tue, Aug 16, 2011 at 09:36:06AM +1000, Stephen Rothwell wrote:
> Commit b33f9cbd67ba ("regmap: Specify a module license") added a
> MODULES_LICENSE to this file without adding an include of module.h.
> module.h should ahve been included anyway, since this file has
> EXPORT_SYMBOLs as well.   With the pending module.h spliit up, this would
> probably caused build problems.

Applied with a few typo fixes to the commit log, thanks.

Re: [PATCH] regmap: using module facilities requires module.h

[Mark Brown]

On Tue, Aug 16, 2011 at 08:41:06AM +0900, Mark Brown wrote:
> On Tue, Aug 16, 2011 at 09:36:06AM +1000, Stephen Rothwell wrote:
> > Commit b33f9cbd67ba ("regmap: Specify a module license") added a
> > MODULES_LICENSE to this file without adding an include of module.h.
> > module.h should ahve been included anyway, since this file has
> > EXPORT_SYMBOLs as well.   With the pending module.h spliit up, this would
> > probably caused build problems.

> Applied with a few typo fixes to the commit log, thanks.

...and backed out again as Linus applied directly anyway (with the same
typo fixes).