* [PATCH] ARM: S3C2443: Remove redundant s3c_register_clocks call for init_clocks
@ 2011-08-16 3:04 Axel Lin
2011-08-16 6:48 ` Heiko Stübner
2011-10-14 7:14 ` Kukjin Kim
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2011-08-16 3:04 UTC (permalink / raw)
To: linux-kernel; +Cc: Ben Dooks, Russell King, linux-arm-kernel
Since commit af337f3e633a198034a99450416257ddf2307497
"ARM: S3C2443: Move parts of the clock code to common clock file",
the init_clocks array is moved to arch/arm/plat-s3c24xx/s3c2443-clock.c.
Now we call s3c_register_clocks for init_clocks in s3c2443_common_init_clocks.
Thus we can remove the empty init_clocks array here and remove the
redundant s3c_register_clocks call for init_clocks in s3c2443_init_clocks.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
arch/arm/mach-s3c2443/clock.c | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-s3c2443/clock.c b/arch/arm/mach-s3c2443/clock.c
index a1a7176..4018dbe 100644
--- a/arch/arm/mach-s3c2443/clock.c
+++ b/arch/arm/mach-s3c2443/clock.c
@@ -305,9 +305,6 @@ static struct clk init_clocks_off[] = {
}
};
-static struct clk init_clocks[] = {
-};
-
/* clocks to add straight away */
static struct clksrc_clk *clksrcs[] __initdata = {
@@ -345,10 +342,6 @@ void __init s3c2443_init_clocks(int xtal)
for (ptr = 0; ptr < ARRAY_SIZE(clksrcs); ptr++)
s3c_register_clksrc(clksrcs[ptr], 1);
- /* register clocks from clock array */
-
- s3c_register_clocks(init_clocks, ARRAY_SIZE(init_clocks));
-
/* We must be careful disabling the clocks we are not intending to
* be using at boot time, as subsystems such as the LCD which do
* their own DMA requests to the bus can cause the system to lockup
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: S3C2443: Remove redundant s3c_register_clocks call for init_clocks
2011-08-16 3:04 [PATCH] ARM: S3C2443: Remove redundant s3c_register_clocks call for init_clocks Axel Lin
@ 2011-08-16 6:48 ` Heiko Stübner
2011-08-16 11:03 ` Ben Dooks
2011-10-14 7:14 ` Kukjin Kim
1 sibling, 1 reply; 4+ messages in thread
From: Heiko Stübner @ 2011-08-16 6:48 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Axel Lin, linux-kernel, Russell King, Ben Dooks, Kukjin Kim
Am Dienstag, 16. August 2011, 05:04:41 schrieb Axel Lin:
> Since commit af337f3e633a198034a99450416257ddf2307497
> "ARM: S3C2443: Move parts of the clock code to common clock file",
> the init_clocks array is moved to arch/arm/plat-s3c24xx/s3c2443-clock.c.
> Now we call s3c_register_clocks for init_clocks in
> s3c2443_common_init_clocks.
>
> Thus we can remove the empty init_clocks array here and remove the
> redundant s3c_register_clocks call for init_clocks in s3c2443_init_clocks.
I'm not 100% sure, but you might want to include Kukjin Kim
<kgene.kim@samsung.com> who seems to be handling the Samsung-stuff most of the
time.
Heiko
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> arch/arm/mach-s3c2443/clock.c | 7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-s3c2443/clock.c b/arch/arm/mach-s3c2443/clock.c
> index a1a7176..4018dbe 100644
> --- a/arch/arm/mach-s3c2443/clock.c
> +++ b/arch/arm/mach-s3c2443/clock.c
> @@ -305,9 +305,6 @@ static struct clk init_clocks_off[] = {
> }
> };
>
> -static struct clk init_clocks[] = {
> -};
> -
> /* clocks to add straight away */
>
> static struct clksrc_clk *clksrcs[] __initdata = {
> @@ -345,10 +342,6 @@ void __init s3c2443_init_clocks(int xtal)
> for (ptr = 0; ptr < ARRAY_SIZE(clksrcs); ptr++)
> s3c_register_clksrc(clksrcs[ptr], 1);
>
> - /* register clocks from clock array */
> -
> - s3c_register_clocks(init_clocks, ARRAY_SIZE(init_clocks));
> -
> /* We must be careful disabling the clocks we are not intending to
> * be using at boot time, as subsystems such as the LCD which do
> * their own DMA requests to the bus can cause the system to lockup
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: S3C2443: Remove redundant s3c_register_clocks call for init_clocks
2011-08-16 6:48 ` Heiko Stübner
@ 2011-08-16 11:03 ` Ben Dooks
0 siblings, 0 replies; 4+ messages in thread
From: Ben Dooks @ 2011-08-16 11:03 UTC (permalink / raw)
To: Heiko Stübner
Cc: linux-arm-kernel, Axel Lin, linux-kernel, Russell King, Ben Dooks,
Kukjin Kim
On Tue, Aug 16, 2011 at 08:48:22AM +0200, Heiko Stübner wrote:
> Am Dienstag, 16. August 2011, 05:04:41 schrieb Axel Lin:
> > Since commit af337f3e633a198034a99450416257ddf2307497
> > "ARM: S3C2443: Move parts of the clock code to common clock file",
> > the init_clocks array is moved to arch/arm/plat-s3c24xx/s3c2443-clock.c.
> > Now we call s3c_register_clocks for init_clocks in
> > s3c2443_common_init_clocks.
> >
> > Thus we can remove the empty init_clocks array here and remove the
> > redundant s3c_register_clocks call for init_clocks in s3c2443_init_clocks.
> I'm not 100% sure, but you might want to include Kukjin Kim
> <kgene.kim@samsung.com> who seems to be handling the Samsung-stuff most of the
> time.
>
> Heiko
I'll pick this up, as there's plans to turn all the mach-s3c24xxs into
one big directory.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> > ---
> > arch/arm/mach-s3c2443/clock.c | 7 -------
> > 1 files changed, 0 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/arm/mach-s3c2443/clock.c b/arch/arm/mach-s3c2443/clock.c
> > index a1a7176..4018dbe 100644
> > --- a/arch/arm/mach-s3c2443/clock.c
> > +++ b/arch/arm/mach-s3c2443/clock.c
> > @@ -305,9 +305,6 @@ static struct clk init_clocks_off[] = {
> > }
> > };
> >
> > -static struct clk init_clocks[] = {
> > -};
> > -
> > /* clocks to add straight away */
> >
> > static struct clksrc_clk *clksrcs[] __initdata = {
> > @@ -345,10 +342,6 @@ void __init s3c2443_init_clocks(int xtal)
> > for (ptr = 0; ptr < ARRAY_SIZE(clksrcs); ptr++)
> > s3c_register_clksrc(clksrcs[ptr], 1);
> >
> > - /* register clocks from clock array */
> > -
> > - s3c_register_clocks(init_clocks, ARRAY_SIZE(init_clocks));
> > -
> > /* We must be careful disabling the clocks we are not intending to
> > * be using at boot time, as subsystems such as the LCD which do
> > * their own DMA requests to the bus can cause the system to lockup
>
--
Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] ARM: S3C2443: Remove redundant s3c_register_clocks call for init_clocks
2011-08-16 3:04 [PATCH] ARM: S3C2443: Remove redundant s3c_register_clocks call for init_clocks Axel Lin
2011-08-16 6:48 ` Heiko Stübner
@ 2011-10-14 7:14 ` Kukjin Kim
1 sibling, 0 replies; 4+ messages in thread
From: Kukjin Kim @ 2011-10-14 7:14 UTC (permalink / raw)
To: 'Axel Lin', linux-kernel
Cc: 'Ben Dooks', 'Russell King', linux-arm-kernel
Axel Lin wrote:
>
> Since commit af337f3e633a198034a99450416257ddf2307497
> "ARM: S3C2443: Move parts of the clock code to common clock file",
> the init_clocks array is moved to arch/arm/plat-s3c24xx/s3c2443-clock.c.
> Now we call s3c_register_clocks for init_clocks in s3c2443_common_init_clocks.
>
> Thus we can remove the empty init_clocks array here and remove the
> redundant s3c_register_clocks call for init_clocks in s3c2443_init_clocks.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> arch/arm/mach-s3c2443/clock.c | 7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-s3c2443/clock.c b/arch/arm/mach-s3c2443/clock.c
> index a1a7176..4018dbe 100644
> --- a/arch/arm/mach-s3c2443/clock.c
> +++ b/arch/arm/mach-s3c2443/clock.c
> @@ -305,9 +305,6 @@ static struct clk init_clocks_off[] = {
> }
> };
>
> -static struct clk init_clocks[] = {
> -};
> -
> /* clocks to add straight away */
>
> static struct clksrc_clk *clksrcs[] __initdata = {
> @@ -345,10 +342,6 @@ void __init s3c2443_init_clocks(int xtal)
> for (ptr = 0; ptr < ARRAY_SIZE(clksrcs); ptr++)
> s3c_register_clksrc(clksrcs[ptr], 1);
>
> - /* register clocks from clock array */
> -
> - s3c_register_clocks(init_clocks, ARRAY_SIZE(init_clocks));
> -
> /* We must be careful disabling the clocks we are not intending to
> * be using at boot time, as subsystems such as the LCD which do
> * their own DMA requests to the bus can cause the system to lockup
> --
> 1.7.4.1
Looks ok, applied.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-14 7:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-16 3:04 [PATCH] ARM: S3C2443: Remove redundant s3c_register_clocks call for init_clocks Axel Lin
2011-08-16 6:48 ` Heiko Stübner
2011-08-16 11:03 ` Ben Dooks
2011-10-14 7:14 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox