Re: [PATCH 11/11] script/checkpatch.pl: warn about deprecated use of EXTRA_{A,C,CPP,LD}FLAGS

Michal Marek
2011-08-31T14:44:18Z

On Mon, Aug 15, 2011 at 01:07:14AM -0400, Arnaud Lacombe wrote:
> Usage of these flags has been deprecated for nearly 4 years by:
>
> commit f77bf01425b11947eeb3b5b54685212c302741b8
> Author: Sam Ravnborg <sam@neptun.(none)>
> Date: Mon Oct 15 22:25:06 2007 +0200
>
> kbuild: introduce ccflags-y, asflags-y and ldflags-y
>
> Moreover, these flags (at least EXTRA_CFLAGS) have been documented for command
> line use. By default, gmake(1) do not override command line setting, so this is
> likely to result in build failure or unexpected behavior.
>
> Warn about their introduction in Makefile or Kbuild files.
>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Andy Whitcroft <apw@canonical.com>
> ---
> scripts/checkpatch.pl | 14 ++++++++++++++
> 1 files changed, 14 insertions(+), 0 deletions(-)

Applied to kbuild-2.6.git#misc with your signoff assumed.

Michal