Re: [PATCH 07/11] drivers/pps: do not use EXTRA_CFLAGS

Arnaud Lacombe
2011-08-15T05:16:35Z

On Mon, Aug 15, 2011 at 1:07 AM, Arnaud Lacombe <lacombar@gmail.com> wrote:
> Usage of these flags has been deprecated for nearly 4 years by:
>
>    commit f77bf01425b11947eeb3b5b54685212c302741b8
>    Author: Sam Ravnborg <sam@neptun.(none)>
>    Date:   Mon Oct 15 22:25:06 2007 +0200
>
>        kbuild: introduce ccflags-y, asflags-y and ldflags-y
>
> Moreover, these flags (at least EXTRA_CFLAGS) have been documented for command
> line use. By default, gmake(1) do not override command line setting, so this is
> likely to result in build failure or unexpected behavior.
>
> Replace their usage by Kbuild's `{as,cc,ld}flags-y'.
>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Rodolfo Giometti <giometti@enneenne.com>
> Cc: linuxpps@ml.enneenne.com
Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>

- Arnaud

> ---
>  drivers/pps/generators/Makefile |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pps/generators/Makefile b/drivers/pps/generators/Makefile
> index 303304a..21e5e3b 100644
> --- a/drivers/pps/generators/Makefile
> +++ b/drivers/pps/generators/Makefile
> @@ -4,6 +4,4 @@
>
>  obj-$(CONFIG_PPS_GENERATOR_PARPORT) += pps_gen_parport.o
>
> -ifeq ($(CONFIG_PPS_DEBUG),y)
> -EXTRA_CFLAGS += -DDEBUG
> -endif
> +ccflags-$(CONFIG_PPS_DEBUG) += -DDEBUG
> --
> 1.7.6.153.g78432
>
>