From: Nicolas Kaiser <nikai@nikai.net>
To: Jeff Brown <jeffbrown@android.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
jkosina@suse.cz, rydberg@euromail.se, chatty@enac.fr,
benjamin.tissoires@enac.fr
Subject: Re: [PATCH] hid-multitouch: Filter collections by application usage.
Date: Tue, 16 Aug 2011 11:43:33 +0200 [thread overview]
Message-ID: <20110816114333.03e1f465@absol.kitzblitz> (raw)
In-Reply-To: <1313451868-79836-1-git-send-email-jeffbrown@android.com>
Just a nit below.
* jeffbrown@android.com:
(..)
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 58d0e7a..4ee21ac 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -213,6 +213,16 @@ static int mt_input_mapping(struct hid_device *hdev, struct hid_input *hi,
> struct mt_class *cls = td->mtclass;
> __s32 quirks = cls->quirks;
>
> + /* Only map fields from TouchScreen or TouchPad collections.
> + * We need to ignore fields that belong to other collections
^
> + * such as Mouse that might have the same GenericDesktop usages. */
^
You might want to use tabs here instead of spaces.
Best regards,
Nicolas Kaiser
prev parent reply other threads:[~2011-08-16 9:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 23:44 [PATCH] hid-multitouch: Filter collections by application usage jeffbrown
2011-08-16 7:29 ` Benjamin Tissoires
2011-08-16 9:39 ` Jiri Kosina
2011-08-16 9:43 ` Nicolas Kaiser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110816114333.03e1f465@absol.kitzblitz \
--to=nikai@nikai.net \
--cc=benjamin.tissoires@enac.fr \
--cc=chatty@enac.fr \
--cc=jeffbrown@android.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox