From: Oleg Nesterov <oleg@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Linas Vepstas <linasvepstas@gmail.com>,
Matt Fleming <matt@console-pimps.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/eeh: remove eeh_event_handler()->daemonize()
Date: Wed, 17 Aug 2011 19:27:13 +0200 [thread overview]
Message-ID: <20110817172713.GA24544@redhat.com> (raw)
In-Reply-To: <20110816192629.GB2803@mtj.dyndns.org>
On 08/16, Tejun Heo wrote:
>
> On Tue, Aug 16, 2011 at 09:08:58PM +0200, Oleg Nesterov wrote:
> > daemonize() is only needed when a user-space task does kernel_thread().
> >
> > eeh_event_handler() thread is created by the worker kthread, and thus
> > it doesn't need the soon-to-be-deprecated daemonize().
> >
> > Note: looks like eeh_event_wq can be static and it can do all work
> > itself without kernel_thread().
> >
> > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
>
> Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
> How do you wanna route these? Through -mm?
Oh, I don't know. -mm, or probably maintainers can pick them.
They don't depend on each other.
Btw. Perhaps we should kill CLONE_KERNEL? And note that the only
user is eeh_thread_launcher().
The problem is, CLONE_KERNEL looks as "use me if you want to create
a kernel thread". But CLONE_SIGHAND means the kernel thread should
not play with signals, and this is not obvious.
Oleg.
next prev parent reply other threads:[~2011-08-17 17:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 19:08 [PATCH] powerpc/eeh: remove eeh_event_handler()->daemonize() Oleg Nesterov
2011-08-16 19:17 ` Benjamin Herrenschmidt
2011-08-16 19:24 ` Linas Vepstas
2011-08-16 19:29 ` Tejun Heo
2011-08-16 21:38 ` Linas Vepstas
2011-08-16 19:26 ` Tejun Heo
2011-08-17 17:27 ` Oleg Nesterov [this message]
2011-08-18 7:34 ` Tejun Heo
2011-08-16 21:27 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110817172713.GA24544@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linasvepstas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=paulus@samba.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox