* [PATCH] Added #include of module.h to s3c_adc_battery.c
@ 2011-08-18 10:14 Ian
2011-08-18 10:21 ` Vasily Khoruzhick
0 siblings, 1 reply; 5+ messages in thread
From: Ian @ 2011-08-18 10:14 UTC (permalink / raw)
To: Anton Vorontsov, u.kleine-koenig, Mark Brown, Vasily Khoruzhick
Cc: linux-kernel
s3c_adc_battery.c will not compile without moule.h as it contains the
definitions of: MODULE_AUTHOR, MODULE_DESCRIPTION & MODULE_LICENSE.
Signed-off-by: Ian Lartey <ian@opensource.wolfsonmicro.com>
---
drivers/power/s3c_adc_battery.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/power/s3c_adc_battery.c b/drivers/power/s3c_adc_battery.c
index a675e31..20770ba 100644
--- a/drivers/power/s3c_adc_battery.c
+++ b/drivers/power/s3c_adc_battery.c
@@ -9,6 +9,7 @@
*
*/
+#include <linux/module.h>
#include <linux/interrupt.h>
#include <linux/platform_device.h>
#include <linux/power_supply.h>
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Added #include of module.h to s3c_adc_battery.c
2011-08-18 10:14 [PATCH] Added #include of module.h to s3c_adc_battery.c Ian
@ 2011-08-18 10:21 ` Vasily Khoruzhick
2011-08-18 10:34 ` Ian
0 siblings, 1 reply; 5+ messages in thread
From: Vasily Khoruzhick @ 2011-08-18 10:21 UTC (permalink / raw)
To: Ian; +Cc: Anton Vorontsov, u.kleine-koenig, Mark Brown, linux-kernel
On Thursday 18 August 2011 13:14:09 Ian wrote:
> s3c_adc_battery.c will not compile without moule.h as it contains the
> definitions of: MODULE_AUTHOR, MODULE_DESCRIPTION & MODULE_LICENSE.
I've already sent pretty same patch a ~week ago, here it is:
https://patchwork.kernel.org/patch/1061302/
Regards
Vasily
>
> Signed-off-by: Ian Lartey <ian@opensource.wolfsonmicro.com>
> ---
> drivers/power/s3c_adc_battery.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/power/s3c_adc_battery.c
> b/drivers/power/s3c_adc_battery.c index a675e31..20770ba 100644
> --- a/drivers/power/s3c_adc_battery.c
> +++ b/drivers/power/s3c_adc_battery.c
> @@ -9,6 +9,7 @@
> *
> */
>
> +#include <linux/module.h>
> #include <linux/interrupt.h>
> #include <linux/platform_device.h>
> #include <linux/power_supply.h>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Added #include of module.h to s3c_adc_battery.c
2011-08-18 10:21 ` Vasily Khoruzhick
@ 2011-08-18 10:34 ` Ian
2011-08-18 16:06 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Ian @ 2011-08-18 10:34 UTC (permalink / raw)
To: Vasily Khoruzhick
Cc: Anton Vorontsov, u.kleine-koenig, Mark Brown, linux-kernel
On Thu, 2011-08-18 at 13:21 +0300, Vasily Khoruzhick wrote:
> On Thursday 18 August 2011 13:14:09 Ian wrote:
> > s3c_adc_battery.c will not compile without moule.h as it contains the
> > definitions of: MODULE_AUTHOR, MODULE_DESCRIPTION & MODULE_LICENSE.
>
> I've already sent pretty same patch a ~week ago, here it is:
> https://patchwork.kernel.org/patch/1061302/
Ah, apologies - please disregard this patch then.
Regards
Ian
>
> Regards
> Vasily
>
> >
> > Signed-off-by: Ian Lartey <ian@opensource.wolfsonmicro.com>
> > ---
> > drivers/power/s3c_adc_battery.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/power/s3c_adc_battery.c
> > b/drivers/power/s3c_adc_battery.c index a675e31..20770ba 100644
> > --- a/drivers/power/s3c_adc_battery.c
> > +++ b/drivers/power/s3c_adc_battery.c
> > @@ -9,6 +9,7 @@
> > *
> > */
> >
> > +#include <linux/module.h>
> > #include <linux/interrupt.h>
> > #include <linux/platform_device.h>
> > #include <linux/power_supply.h>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Added #include of module.h to s3c_adc_battery.c
2011-08-18 10:34 ` Ian
@ 2011-08-18 16:06 ` Mark Brown
2011-08-19 16:55 ` Anton Vorontsov
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2011-08-18 16:06 UTC (permalink / raw)
To: Ian; +Cc: Vasily Khoruzhick, Anton Vorontsov, u.kleine-koenig, linux-kernel
On Thu, Aug 18, 2011 at 11:34:48AM +0100, Ian wrote:
> On Thu, 2011-08-18 at 13:21 +0300, Vasily Khoruzhick wrote:
> > On Thursday 18 August 2011 13:14:09 Ian wrote:
> > > s3c_adc_battery.c will not compile without moule.h as it contains the
> > > definitions of: MODULE_AUTHOR, MODULE_DESCRIPTION & MODULE_LICENSE.
> >
> > I've already sent pretty same patch a ~week ago, here it is:
> > https://patchwork.kernel.org/patch/1061302/
>
> Ah, apologies - please disregard this patch then.
Hrm, Anton's been pretty quiet recently - might be an idea to start
CCing akpm on this stuff?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Added #include of module.h to s3c_adc_battery.c
2011-08-18 16:06 ` Mark Brown
@ 2011-08-19 16:55 ` Anton Vorontsov
0 siblings, 0 replies; 5+ messages in thread
From: Anton Vorontsov @ 2011-08-19 16:55 UTC (permalink / raw)
To: Mark Brown; +Cc: Ian, Vasily Khoruzhick, u.kleine-koenig, linux-kernel
On Fri, Aug 19, 2011 at 01:06:13AM +0900, Mark Brown wrote:
> On Thu, Aug 18, 2011 at 11:34:48AM +0100, Ian wrote:
> > On Thu, 2011-08-18 at 13:21 +0300, Vasily Khoruzhick wrote:
> > > On Thursday 18 August 2011 13:14:09 Ian wrote:
> > > > s3c_adc_battery.c will not compile without moule.h as it contains the
> > > > definitions of: MODULE_AUTHOR, MODULE_DESCRIPTION & MODULE_LICENSE.
> > >
> > > I've already sent pretty same patch a ~week ago, here it is:
> > > https://patchwork.kernel.org/patch/1061302/
> >
> > Ah, apologies - please disregard this patch then.
>
> Hrm, Anton's been pretty quiet recently - might be an idea to start
> CCing akpm on this stuff?
Don't panic. :-) I'm still here, been on a vacation (and was trying to
not read emails :-), then was catching up with my other duties.
Ian, I added your Signed-off-by line to the Vasily's patch, for
the credits.
Thank you!
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-08-19 16:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-18 10:14 [PATCH] Added #include of module.h to s3c_adc_battery.c Ian
2011-08-18 10:21 ` Vasily Khoruzhick
2011-08-18 10:34 ` Ian
2011-08-18 16:06 ` Mark Brown
2011-08-19 16:55 ` Anton Vorontsov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox