From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756057Ab1HRQZa (ORCPT ); Thu, 18 Aug 2011 12:25:30 -0400 Received: from hera.kernel.org ([140.211.167.34]:33477 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755295Ab1HRQZ3 (ORCPT ); Thu, 18 Aug 2011 12:25:29 -0400 Date: Thu, 18 Aug 2011 18:24:19 +0200 From: Ingo Molnar To: Tracey Dent Cc: Randy Dunlap , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, gregkh@suse.de Subject: Re: [PATCH 1/1] misc/pti.c: Fix build error when PCI is not selected Message-ID: <20110818162419.GA26627@kernel.org> References: <20110811162306.GA30710@tj-desktop> <20110811094520.4ee7819f.rdunlap@xenotime.net> <20110811165911.GA6454@tj-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20110811165911.GA6454@tj-desktop> User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.6 (hera.kernel.org [127.0.0.1]); Thu, 18 Aug 2011 16:25:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Tracey Dent wrote: > On Thu, Aug 11, 2011 at 09:45:20AM -0700, Randy Dunlap wrote: > > On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote: > > > > > When you try to build INTEL_MID_PTI without having PCI > > > enabled. It fails like this- > > > > > > CC [M] drivers/misc/pti.o > > > drivers/misc/pti.c: In function ‘pti_pci_remove’: > > > drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’ > > > drivers/misc/pti.c: In function ‘pti_pci_probe’: > > > drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’ > > > > > > So make INTEL_MID_PTI depend on PCI to fix build error. > > > > I think (hope) that Greg already has a patch like this queued. > > Greg- are you planning to push some patches soon? > > > > > > Okay, sorry for the noise then. FYI, The fix is still not upstream, as of today's -git (72ed62bdc46d): drivers/misc/pti.c:410:3: error: implicit declaration of function ‘pci_release_region’ [-Werror=implicit-function-declaration] drivers/misc/pti.c:859:2: error: implicit declaration of function ‘pci_request_region’ [-Werror=implicit-function-declaration] Thanks, Ingo