From: Don Zickus <dzickus@redhat.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Matthew Garrett <mjg@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: pstore: change mutex locking to spin_locks
Date: Thu, 18 Aug 2011 13:25:02 -0400 [thread overview]
Message-ID: <20110818172502.GF1972@redhat.com> (raw)
In-Reply-To: <987664A83D2D224EAE907B061CE93D5301EA4D7C88@orsmsx505.amr.corp.intel.com>
On Thu, Aug 18, 2011 at 09:33:17AM -0700, Luck, Tony wrote:
> > But in this case we have a filesystem that can be read/written to from a
> > normal context and also written to from an NMI context
>
> I fixed (avoided) the problem of writing to the pstore filesystem in NMI
> context in my other pstore patch in linux-next ("defer inserting OOPS entries in pstore").
Ok, just found that patch. That fixes one of the issues. :-)
>
> So the remaining locking requirement in pstore is just to protect
> the non-volatile backing store from simultaneous access.
Right. It is still awkward to have userspace write to the pstore and then
be interrupted by an NMI who wants to write to the pstore without causing
deadlocks. But I think we will get there.
Cheers,
Don
prev parent reply other threads:[~2011-08-18 17:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 17:54 pstore: change mutex locking to spin_locks Luck, Tony
2011-08-12 17:59 ` Matthew Garrett
2011-08-17 21:22 ` Andrew Morton
2011-08-17 21:47 ` Peter Zijlstra
2011-08-18 13:04 ` Don Zickus
2011-08-18 15:26 ` Peter Zijlstra
2011-08-18 12:58 ` Don Zickus
2011-08-18 14:37 ` Peter Zijlstra
2011-08-18 16:33 ` Luck, Tony
2011-08-18 17:25 ` Don Zickus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110818172502.GF1972@redhat.com \
--to=dzickus@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mjg@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox