public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Markus Rechberger <mrechberger@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Increase usbfs bulk buffer size
Date: Thu, 18 Aug 2011 11:37:12 -0700	[thread overview]
Message-ID: <20110818183712.GC18881@suse.de> (raw)
In-Reply-To: <CA+O4pCKfWLP+ohfUVi811CRbmrb2FyoMwkmxxGJ1TF2kKtGDEA@mail.gmail.com>

On Wed, Aug 17, 2011 at 07:07:01PM +0200, Markus Rechberger wrote:
> Hi,
> 
> this patch increases the maximum buffersize for bulk transfers, our
> devices support at least up to 46k bytes for bulk transfers.
> This patch allows us to lower the iterations between kernel and
> userspace and lower the system pressure.

But as Oliver pointed out, this increases the memory pressure.  I'm
curious why you say there is "system pressure" with the current buffer
size.  What is the problems here, you are just passing the same logic
issues down to the kernel, that you should be handling in userspace if
you want to use usbfs.

> Signed-off-by: Markus Rechberger <mrechberger@gmail.com>

Also note that this is a user/kernel API that you are changing, are you
_sure_ you didn't just break some user code with this change that was
assuming that the buffer size was 16Kb, as it's been that way for the
past 10 years?

thanks,

greg k-h

  parent reply	other threads:[~2011-08-18 18:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-17 17:07 [PATCH] Increase usbfs bulk buffer size Markus Rechberger
2011-08-17 17:14 ` Oliver Neukum
2011-08-17 17:44   ` Markus Rechberger
2011-08-19  6:23     ` Oliver Neukum
2011-08-19 10:45       ` Markus Rechberger
2011-08-31  6:57         ` Markus Rechberger
2011-09-12 10:18           ` Markus Rechberger
2011-09-12 10:25             ` Markus Rechberger
2011-09-12 11:33             ` Greg KH
2011-09-12 12:14               ` Markus Rechberger
2011-09-12 14:07                 ` Alan Stern
2011-08-18 18:37 ` Greg KH [this message]
2011-08-18 19:13   ` Markus Rechberger
2011-08-19  5:26     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110818183712.GC18881@suse.de \
    --to=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mrechberger@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox