From: Greg KH <gregkh@suse.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: Tracey Dent <tdent48227@gmail.com>,
Randy Dunlap <rdunlap@xenotime.net>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 1/1] misc/pti.c: Fix build error when PCI is not selected
Date: Thu, 18 Aug 2011 11:39:39 -0700 [thread overview]
Message-ID: <20110818183939.GD18881@suse.de> (raw)
In-Reply-To: <20110818162419.GA26627@kernel.org>
On Thu, Aug 18, 2011 at 06:24:19PM +0200, Ingo Molnar wrote:
>
> * Tracey Dent <tdent48227@gmail.com> wrote:
>
> > On Thu, Aug 11, 2011 at 09:45:20AM -0700, Randy Dunlap wrote:
> > > On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote:
> > >
> > > > When you try to build INTEL_MID_PTI without having PCI
> > > > enabled. It fails like this-
> > > >
> > > > CC [M] drivers/misc/pti.o
> > > > drivers/misc/pti.c: In function ‘pti_pci_remove’:
> > > > drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’
> > > > drivers/misc/pti.c: In function ‘pti_pci_probe’:
> > > > drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’
> > > >
> > > > So make INTEL_MID_PTI depend on PCI to fix build error.
> > >
> > > I think (hope) that Greg already has a patch like this queued.
> > > Greg- are you planning to push some patches soon?
> > >
> > >
> >
> > Okay, sorry for the noise then.
>
> FYI, The fix is still not upstream, as of today's -git
> (72ed62bdc46d):
>
> drivers/misc/pti.c:410:3: error: implicit declaration of function ‘pci_release_region’ [-Werror=implicit-function-declaration]
> drivers/misc/pti.c:859:2: error: implicit declaration of function ‘pci_request_region’ [-Werror=implicit-function-declaration]
Yes, sorry, stuck at LinuxCon this week, will get it to Linus next week.
He's busy as well, so it's not like he could pull while underwater
anyway :)
greg k-h
next prev parent reply other threads:[~2011-08-18 18:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 16:23 [PATCH 1/1] misc/pti.c: Fix build error when PCI is not selected Tracey Dent
2011-08-11 16:45 ` Randy Dunlap
2011-08-11 16:56 ` Greg KH
2011-08-11 16:59 ` Tracey Dent
2011-08-18 16:24 ` Ingo Molnar
2011-08-18 18:39 ` Greg KH [this message]
2011-08-18 20:29 ` Ingo Molnar
2011-08-19 18:52 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110818183939.GD18881@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rdunlap@xenotime.net \
--cc=tdent48227@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox