From: Anton Vorontsov <cbouatmailru@gmail.com>
To: ashishj3 <ashish.jangam@kpitcummins.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
linaro-dev@lists.linaro.org, dwmw2@infradead.org,
linux-kernel@vger.kernel.org, Dajun <dajun.chen@diasemi.com>
Subject: Re: [Patch v2 04/11]Power: DA9052 battery driver
Date: Fri, 19 Aug 2011 20:27:41 +0400 [thread overview]
Message-ID: <20110819162741.GC22761@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1312462072.2388.1.camel@L-0532.kpit.com>
On Thu, Aug 04, 2011 at 06:17:52PM +0530, ashishj3 wrote:
> On Fri, 2011-07-22 at 18:22 +0530, ashishj3 wrote:
> > Driver for DA9052 battery charger. This driver depends on DA9052 MFD core dirver
> > for definitions and methods.
> >
> > Signed-off-by: David Dajun Chen <dchen@diasemi.com>
> > Signed-off-by: Ashish Jangam <ashish.jangam@kpitcummins.com>
> > ---
> > Changes since v2
> > - Correct code styling for inline functions
> > - Remove averaging algorithm
> > - Set use_for_apm thru board specific parameter
> > ---
> Any comments on this patch?
Despite some cosmetic issues, the patch looks OK to me.
So, I'm fine if it goes via MFD tree.
Although, if you ever need to respin this patch, try to make the
code fully conform to the Linux coding style.
Thanks,
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
next prev parent reply other threads:[~2011-08-19 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 12:52 [Patch v2 04/11]Power: DA9052 battery driver ashishj3
2011-08-04 12:47 ` ashishj3
2011-08-19 16:27 ` Anton Vorontsov [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-08-16 8:04 Ashish Jangam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110819162741.GC22761@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=ashish.jangam@kpitcummins.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dajun.chen@diasemi.com \
--cc=dwmw2@infradead.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox