From: Oleg Nesterov <oleg@redhat.com>
To: bookjovi@gmail.com
Cc: dhowells@redhat.com, nhorman@tuxdriver.com, roland@redhat.com,
viro@zeniv.linux.org.uk, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coredump: fix pipe coredump when core limit is 0
Date: Sun, 21 Aug 2011 17:57:56 +0200 [thread overview]
Message-ID: <20110821155756.GA316@redhat.com> (raw)
In-Reply-To: <20110821152545.GA30955@redhat.com>
On 08/21, Oleg Nesterov wrote:
>
> On 08/21, bookjovi@gmail.com wrote:
> >
> > For non-pipe case, limit 0 also means drop the coredump, so just put
> > the zero limit check at do_coredump function begining.
>
> Neil, what do you think? Should we change the code or the comment?
Personally I think we should fix the comment. I think RLIMIT_CORE
doesn't apply in this case, limit == 1 check is very special. And
this is what linux always did, except between 725eae32 and 898b374a.
Oleg.
next prev parent reply other threads:[~2011-08-21 16:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-21 11:25 [PATCH] coredump: fix pipe coredump when core limit is 0 bookjovi
2011-08-21 15:25 ` Oleg Nesterov
2011-08-21 15:57 ` Oleg Nesterov [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-08-21 22:36 Neil Horman
2011-08-22 13:23 ` Jovi Zhang
2011-08-22 13:27 ` Oleg Nesterov
2011-08-22 15:32 ` Pádraig Brady
2011-08-22 16:19 ` Oleg Nesterov
2011-08-24 10:14 ` Jovi Zhang
2011-08-24 10:17 ` Jovi Zhang
2011-08-24 11:01 ` Neil Horman
2011-08-25 10:03 ` Pádraig Brady
2011-08-25 10:55 ` Neil Horman
2011-08-26 9:15 ` Pádraig Brady
2011-08-25 15:57 ` Oleg Nesterov
2011-08-25 18:43 ` Neil Horman
2011-08-26 14:11 ` Oleg Nesterov
2011-08-26 15:39 ` Neil Horman
2011-08-26 9:09 ` Pádraig Brady
2011-08-26 14:10 ` Oleg Nesterov
2011-11-14 5:49 ` Jovi Zhang
2012-07-07 11:35 ` Jovi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110821155756.GA316@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bookjovi@gmail.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=roland@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox