From: Samuel Ortiz <sameo@linux.intel.com>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Karl Komierowski <karl.komierowski@stericsson.com>,
Kalle Komierowski <kalle.komierowski@stericsson.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] mfd/ab8500-gpadc: refactor GPADC API, add raw access
Date: Mon, 22 Aug 2011 15:09:52 +0200 [thread overview]
Message-ID: <20110822130952.GN4607@sortiz-mobl> (raw)
In-Reply-To: <1312981783-19117-1-git-send-email-linus.walleij@stericsson.com>
Hi Linus,
On Wed, Aug 10, 2011 at 03:09:43PM +0200, Linus Walleij wrote:
> From: Karl Komierowski <karl.komierowski@stericsson.com>
>
> Refactor the GPADC interface to avoid bugs in calling code:
>
> - ab8500_gpadc_[convert|read_raw|ad_to_voltage] clarifies
> each functions use case, *convert wraps *read_raw, and we
> can access raw ADC values properly.
> - Renamed gpadc function arguments from "input" to "channel" to
> clarify use, so we don't get confused again.
Ok, thanks for the clarification.
Patch applied now.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2011-08-22 13:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 13:09 [PATCH] mfd/ab8500-gpadc: refactor GPADC API, add raw access Linus Walleij
2011-08-22 13:09 ` Samuel Ortiz [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-06-28 9:08 Linus Walleij
2011-07-04 15:30 ` Samuel Ortiz
2011-08-10 13:06 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110822130952.GN4607@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=kalle.komierowski@stericsson.com \
--cc=karl.komierowski@stericsson.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox