[PATCH] xhci: Redundant check for

[PATCH] xhci: Redundant check for

[sifram rajas]

Hi Sarah,

This patch is for linux-3.0.3.

In the xhci_check_args() function in xhci.c, there is a redundant
check for xhci->devs.

This is redundant because the struct xhci_hcd->devs is actually
defined as a static array
of pointers and is not a pointer to a pointer.

Signed-off-by: Sifram Rajas <sifram.rajas@gmail.com>
---
drivers/usb/host/xhci.c |   3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
--- a/drivers/usb/host/xhci.c	2011-08-17 23:27:16.000000000 +0530
+++ b/drivers/usb/host/xhci.c	2011-08-22 20:43:34.250000000 +0530
@@ -945,8 +945,7 @@ static int xhci_check_args(struct usb_hc
 		return -ENODEV;

 	if (check_virt_dev) {
-		if (!udev->slot_id || !xhci->devs
-			|| !xhci->devs[udev->slot_id]) {
+		if (!udev->slot_id || !xhci->devs[udev->slot_id]) {
 			printk(KERN_DEBUG "xHCI %s called with unaddressed "
 						"device\n", func);
 			return -EINVAL;

Thanks,
Sifram Rajas.

Re: [PATCH] xhci: Redundant check for

[Sarah Sharp]

Hi Sifram,


On Mon, Aug 22, 2011 at 08:35:20AM -0700, sifram rajas wrote:
> Hi Sarah,
> 
> This patch is for linux-3.0.3.
> 
> In the xhci_check_args() function in xhci.c, there is a redundant
> check for xhci->devs.
> 
> This is redundant because the struct xhci_hcd->devs is actually
> defined as a static array
> of pointers and is not a pointer to a pointer.

Your patch looks fine, and I'll apply it to my usb-next branch later
this week.

However, can you please send future patches to
sarah.a.sharp@linux.intel.com, not my intel.com address?  The intel.com
one runs through a horrible exchange server that converts tabs to spaces
and makes it impossible to apply patches.

Where did you find the intel.com email address?  I'm pretty sure the
MAINTAINERS file lists the linux.intel.com one, and I'd like to make
sure people aren't getting bad information.

Sarah Sharp

> Signed-off-by: Sifram Rajas <sifram.rajas@gmail.com>
> ---
> drivers/usb/host/xhci.c |   3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> --- a/drivers/usb/host/xhci.c	2011-08-17 23:27:16.000000000 +0530
> +++ b/drivers/usb/host/xhci.c	2011-08-22 20:43:34.250000000 +0530
> @@ -945,8 +945,7 @@ static int xhci_check_args(struct usb_hc
>  		return -ENODEV;
> 
>  	if (check_virt_dev) {
> -		if (!udev->slot_id || !xhci->devs
> -			|| !xhci->devs[udev->slot_id]) {
> +		if (!udev->slot_id || !xhci->devs[udev->slot_id]) {
>  			printk(KERN_DEBUG "xHCI %s called with unaddressed "
>  						"device\n", func);
>  			return -EINVAL;
> 
> Thanks,
> Sifram Rajas.

Re: [PATCH] xhci: Redundant check for

[Kautuk Consul]

Hi,

Thanks for replying back.

Really sorry about your email address, Sarah.

I think it was a typo. Ill take of emailing you at
sarah.a.sharp@linux.intel.com in future, starting from this email.

Regards,
Kautuk.


On Mon, Aug 22, 2011 at 9:25 PM, Sarah Sharp <sarah.a.sharp@intel.com> wrote:
> Hi Sifram,
>
>
> On Mon, Aug 22, 2011 at 08:35:20AM -0700, sifram rajas wrote:
>> Hi Sarah,
>>
>> This patch is for linux-3.0.3.
>>
>> In the xhci_check_args() function in xhci.c, there is a redundant
>> check for xhci->devs.
>>
>> This is redundant because the struct xhci_hcd->devs is actually
>> defined as a static array
>> of pointers and is not a pointer to a pointer.
>
> Your patch looks fine, and I'll apply it to my usb-next branch later
> this week.
>
> However, can you please send future patches to
> sarah.a.sharp@linux.intel.com, not my intel.com address?  The intel.com
> one runs through a horrible exchange server that converts tabs to spaces
> and makes it impossible to apply patches.
>
> Where did you find the intel.com email address?  I'm pretty sure the
> MAINTAINERS file lists the linux.intel.com one, and I'd like to make
> sure people aren't getting bad information.
>
> Sarah Sharp
>
>> Signed-off-by: Sifram Rajas <sifram.rajas@gmail.com>
>> ---
>> drivers/usb/host/xhci.c |   3 +--
>>  1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
>> --- a/drivers/usb/host/xhci.c 2011-08-17 23:27:16.000000000 +0530
>> +++ b/drivers/usb/host/xhci.c 2011-08-22 20:43:34.250000000 +0530
>> @@ -945,8 +945,7 @@ static int xhci_check_args(struct usb_hc
>>               return -ENODEV;
>>
>>       if (check_virt_dev) {
>> -             if (!udev->slot_id || !xhci->devs
>> -                     || !xhci->devs[udev->slot_id]) {
>> +             if (!udev->slot_id || !xhci->devs[udev->slot_id]) {
>>                       printk(KERN_DEBUG "xHCI %s called with unaddressed "
>>                                               "device\n", func);
>>                       return -EINVAL;
>>
>> Thanks,
>> Sifram Rajas.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Re: [PATCH] xhci: Redundant check for

[Sebastian Andrzej Siewior]

* Sarah Sharp | 2011-08-22 08:55:29 [-0700]:

>Where did you find the intel.com email address?  I'm pretty sure the
>MAINTAINERS file lists the linux.intel.com one, and I'd like to make
>sure people aren't getting bad information.

It is listed in Documentation/ABI/testing/sysfs-bus-usb. But for this
kind of information the exchange server might work :)

>
>Sarah Sharp

Sebastian