Re: [PATCH] coredump: fix pipe coredump when core limit is 0

[Oleg Nesterov <oleg@redhat.com>]

On 08/22, Pádraig Brady wrote:
>
> On 08/21/2011 11:36 PM, Neil Horman wrote:
> > Concur.  The comment should be changed
> > Neil
> >
> > Oleg Nesterov <oleg@redhat.com> wrote:
> >
> >> On 08/21, Oleg Nesterov wrote:
> >>>
> >>> On 08/21, bookjovi@gmail.com wrote:
> >>>>
> >>>> For non-pipe case, limit 0 also means drop the coredump, so just put
> >>>> the zero limit check at do_coredump function begining.
> >>>
> >>> Neil, what do you think? Should we change the code or the comment?
> >>
> >> Personally I think we should fix the comment. I think RLIMIT_CORE
> >> doesn't apply in this case, limit == 1 check is very special. And
> >> this is what linux always did, except between 725eae32 and 898b374a.
>
> Sorry for jumping in late here.
> I would really like `ulimit -c 0` to completely disable core dumps,
> including not running core_pattern, as I also mentioned here:
> https://bugs.launchpad.net/ubuntu/+source/apport/+bug/62511
> I noticed this in a script where ctrl-\ was taking a long
> time to be registered as the core_pattern was run unconditionally.

May be. As I said, I do not really know and personally I agree with
everything. My only point was, this is not the bug, this is what we
always did.

This is up to Neil, I think.

Oleg.