From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Chris Boot <bootc@bootc.net>
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v3] firewire-sbp2: fix panic after rmmod with slow targets
Date: Tue, 23 Aug 2011 01:21:35 +0200 [thread overview]
Message-ID: <20110823012135.61aaf27d@stein> (raw)
In-Reply-To: <1314053771-29944-1-git-send-email-bootc@bootc.net>
On Aug 22 Chris Boot wrote:
> --- a/drivers/firewire/sbp2.c
> +++ b/drivers/firewire/sbp2.c
> @@ -1198,6 +1198,11 @@ static int sbp2_remove(struct device *dev)
> {
> struct fw_unit *unit = fw_unit(dev);
> struct sbp2_target *tgt = dev_get_drvdata(&unit->device);
> + struct sbp2_logical_unit *lu;
> +
> + list_for_each_entry(lu, &tgt->lu_list, link) {
> + cancel_delayed_work_sync(&lu->work);
> + }
>
> sbp2_target_put(tgt);
> return 0;
Thanks. I reproduced the bug, applied your patch, and confirmed that the
patch fixes the bug. Committed to linux1394-2.6.git but without the
curly braces.
--
Stefan Richter
-=====-==-== =--- =-===
http://arcgraph.de/sr/
next prev parent reply other threads:[~2011-08-22 23:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1314017561-1976-1-git-send-email-bootc@bootc.net>
2011-08-22 14:35 ` [PATCH] firewire-sbp2: fix panic after rmmod with slow targets Stefan Richter
2011-08-22 20:38 ` Chris Boot
2011-08-22 22:38 ` Chris Boot
2011-08-22 22:56 ` [PATCH] [v3] " Chris Boot
2011-08-22 23:21 ` Stefan Richter [this message]
2011-08-22 20:43 ` [PATCH] " Chris Boot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110823012135.61aaf27d@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=bootc@bootc.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox