From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Dima Zavin <dima@android.com>
Subject: Re: [PATCH] pda_power: fix build error if !CONFIG_USB_OTG_UTILS
Date: Tue, 23 Aug 2011 17:30:09 +0400 [thread overview]
Message-ID: <20110823133009.GB1352@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1314102873.16518.2.camel@phoenix>
On Tue, Aug 23, 2011 at 08:34:33PM +0800, Axel Lin wrote:
> commit 9ad63986c606c60e2e916b1b96f22991f966d9cc
> "pda_power: Add support for using otg transceiver events"
> introduces below build error if !CONFIG_USB_OTG_UTILS.
>
> CC drivers/power/pda_power.o
> drivers/power/pda_power.c: In function 'pda_power_probe':
> drivers/power/pda_power.c:322: error: 'otg_is_usb_online' undeclared (first use in this function)
> drivers/power/pda_power.c:322: error: (Each undeclared identifier is reported only once
> drivers/power/pda_power.c:322: error: for each function it appears in.)
> drivers/power/pda_power.c:325: error: 'otg_is_ac_online' undeclared (first use in this function)
> drivers/power/pda_power.c:371: error: 'otg_handle_notification' undeclared (first use in this function)
> make[2]: *** [drivers/power/pda_power.o] Error 1
> make[1]: *** [drivers/power] Error 2
> make: *** [drivers] Error 2
>
> This patch adds #ifdef CONFIG_USB_OTG_UTILS guards at necessary places to fix
> build errors.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
Applied, thanks!
Dima,
I wonder if it is possible to get rid of most #ifdefs by moving
the pda_power's USB_OTG stuff into a function?
Thanks,
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
prev parent reply other threads:[~2011-08-23 13:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 12:34 [PATCH] pda_power: fix build error if !CONFIG_USB_OTG_UTILS Axel Lin
2011-08-23 13:30 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110823133009.GB1352@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=axel.lin@gmail.com \
--cc=dima@android.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox