From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Vasily Khoruzhick <anarsoul@gmail.com>
Subject: Re: [PATCH] power_supply: s3c_adc_battery: Needs module.h
Date: Tue, 23 Aug 2011 17:52:31 +0400 [thread overview]
Message-ID: <20110823135231.GA5087@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1313910101.15589.0.camel@phoenix>
On Sun, Aug 21, 2011 at 03:01:41PM +0800, Axel Lin wrote:
> power/s3c_adc_battery:.c uses interfaces from linux/module.h,
> so it should include that file.
>
> This patch fixes below build error:
>
> CC drivers/power/s3c_adc_battery.o
> drivers/power/s3c_adc_battery.c:435: error: expected declaration specifiers or '...' before string constant
> drivers/power/s3c_adc_battery.c:435: warning: data definition has no type or storage class
> drivers/power/s3c_adc_battery.c:435: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
> drivers/power/s3c_adc_battery.c:435: warning: function declaration isn't a prototype
> drivers/power/s3c_adc_battery.c:436: error: expected declaration specifiers or '...' before string constant
> drivers/power/s3c_adc_battery.c:436: warning: data definition has no type or storage class
> drivers/power/s3c_adc_battery.c:436: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
> drivers/power/s3c_adc_battery.c:436: warning: function declaration isn't a prototype
> drivers/power/s3c_adc_battery.c:437: error: expected declaration specifiers or '...' before string constant
> drivers/power/s3c_adc_battery.c:437: warning: data definition has no type or storage class
> drivers/power/s3c_adc_battery.c:437: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> drivers/power/s3c_adc_battery.c:437: warning: function declaration isn't a prototype
> make[2]: *** [drivers/power/s3c_adc_battery.o] Error 1
> make[1]: *** [drivers/power] Error 2
> make: *** [drivers] Error 2
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
Vasily Khoruzhick sent a similar fix.
I'm going to send a pull request with these fixes soon.
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
prev parent reply other threads:[~2011-08-23 13:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-21 7:01 [PATCH] power_supply: s3c_adc_battery: Needs module.h Axel Lin
2011-08-23 13:52 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110823135231.GA5087@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=anarsoul@gmail.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox