[PATCH] power_supply: s3c_adc_battery: Needs module.h

[PATCH] power_supply: s3c_adc_battery: Needs module.h

[Axel Lin]

power/s3c_adc_battery:.c uses interfaces from linux/module.h,
so it should include that file.

This patch fixes below build error:

  CC      drivers/power/s3c_adc_battery.o
drivers/power/s3c_adc_battery.c:435: error: expected declaration specifiers or '...' before string constant
drivers/power/s3c_adc_battery.c:435: warning: data definition has no type or storage class
drivers/power/s3c_adc_battery.c:435: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
drivers/power/s3c_adc_battery.c:435: warning: function declaration isn't a prototype
drivers/power/s3c_adc_battery.c:436: error: expected declaration specifiers or '...' before string constant
drivers/power/s3c_adc_battery.c:436: warning: data definition has no type or storage class
drivers/power/s3c_adc_battery.c:436: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
drivers/power/s3c_adc_battery.c:436: warning: function declaration isn't a prototype
drivers/power/s3c_adc_battery.c:437: error: expected declaration specifiers or '...' before string constant
drivers/power/s3c_adc_battery.c:437: warning: data definition has no type or storage class
drivers/power/s3c_adc_battery.c:437: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
drivers/power/s3c_adc_battery.c:437: warning: function declaration isn't a prototype
make[2]: *** [drivers/power/s3c_adc_battery.o] Error 1
make[1]: *** [drivers/power] Error 2
make: *** [drivers] Error 2

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/power/s3c_adc_battery.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/power/s3c_adc_battery.c b/drivers/power/s3c_adc_battery.c
index a675e31..20770ba 100644
--- a/drivers/power/s3c_adc_battery.c
+++ b/drivers/power/s3c_adc_battery.c
@@ -9,6 +9,7 @@
  *
  */
 
+#include <linux/module.h>
 #include <linux/interrupt.h>
 #include <linux/platform_device.h>
 #include <linux/power_supply.h>
-- 
1.7.4.1

Re: [PATCH] power_supply: s3c_adc_battery: Needs module.h

[Anton Vorontsov]

On Sun, Aug 21, 2011 at 03:01:41PM +0800, Axel Lin wrote:
> power/s3c_adc_battery:.c uses interfaces from linux/module.h,
> so it should include that file.
> 
> This patch fixes below build error:
> 
>   CC      drivers/power/s3c_adc_battery.o
> drivers/power/s3c_adc_battery.c:435: error: expected declaration specifiers or '...' before string constant
> drivers/power/s3c_adc_battery.c:435: warning: data definition has no type or storage class
> drivers/power/s3c_adc_battery.c:435: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
> drivers/power/s3c_adc_battery.c:435: warning: function declaration isn't a prototype
> drivers/power/s3c_adc_battery.c:436: error: expected declaration specifiers or '...' before string constant
> drivers/power/s3c_adc_battery.c:436: warning: data definition has no type or storage class
> drivers/power/s3c_adc_battery.c:436: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
> drivers/power/s3c_adc_battery.c:436: warning: function declaration isn't a prototype
> drivers/power/s3c_adc_battery.c:437: error: expected declaration specifiers or '...' before string constant
> drivers/power/s3c_adc_battery.c:437: warning: data definition has no type or storage class
> drivers/power/s3c_adc_battery.c:437: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> drivers/power/s3c_adc_battery.c:437: warning: function declaration isn't a prototype
> make[2]: *** [drivers/power/s3c_adc_battery.o] Error 1
> make[1]: *** [drivers/power] Error 2
> make: *** [drivers] Error 2
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---

Vasily Khoruzhick sent a similar fix.

I'm going to send a pull request with these fixes soon.

-- 
Anton Vorontsov
Email: cbouatmailru@gmail.com