public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: kernel-hardening@lists.openwall.com,
	Al Viro <viro@zeniv.linux.org.uk>,
	David Rientjes <rientjes@google.com>,
	Stephen Wilson <wilsons@start.ca>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	linux-kernel@vger.kernel.org, security@kernel.org
Subject: Re: [PATCH] proc: fix races of /proc/PID/{fd/,fdinfo/,fdinfo/*}
Date: Tue, 23 Aug 2011 14:44:30 -0700	[thread overview]
Message-ID: <20110823144430.75315ce8.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110804162009.GA2469@albatros>

On Thu, 4 Aug 2011 20:20:09 +0400
Vasiliy Kulikov <segoon@openwall.com> wrote:

> fd* files are restricted to the task's owner, but keeping opened procfs
> file descriptors makes it possible to violate the permission model.
> Keeping fdinfo/* may disclosure current position and flags, keeping
> fdinfo/ and fd/ may disclosure number of opened files.
> 
> Used existing (un)lock_trace functions to deal with the race.

what race.

When fixing a bug, please completely, utterly and exhaustively describe
the bug!

> CC: Stable Tree <stable@kernel.org>

And when cc'ing -stable, please make it very clear why you consider the
bug sufficiently serious to warant mackporting the fix into earlier
kernels.


  reply	other threads:[~2011-08-23 21:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-04 16:20 [PATCH] proc: fix races of /proc/PID/{fd/,fdinfo/,fdinfo/*} Vasiliy Kulikov
2011-08-23 21:44 ` Andrew Morton [this message]
2011-08-26 13:29   ` [PATCH] proc: fix races against execve() " Vasiliy Kulikov
2011-08-26 19:40     ` Andrew Morton
2011-08-27 19:01       ` [PATCH v2] proc: fix races against execve() of /proc/PID/fd** Vasiliy Kulikov
2011-08-27 19:08         ` Vasiliy Kulikov
2011-08-28  9:25         ` Cyrill Gorcunov
2011-08-28  9:31           ` Vasiliy Kulikov
2011-08-29 18:00             ` [PATCH v3] " Vasiliy Kulikov
2011-08-29 23:00               ` Andrew Morton
2011-08-29 23:02               ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110823144430.75315ce8.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rientjes@google.com \
    --cc=security@kernel.org \
    --cc=segoon@openwall.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=wilsons@start.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox