From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754818Ab1HWVp0 (ORCPT ); Tue, 23 Aug 2011 17:45:26 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:52929 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752108Ab1HWVpU (ORCPT ); Tue, 23 Aug 2011 17:45:20 -0400 Date: Tue, 23 Aug 2011 14:44:30 -0700 From: Andrew Morton To: Vasiliy Kulikov Cc: kernel-hardening@lists.openwall.com, Al Viro , David Rientjes , Stephen Wilson , KOSAKI Motohiro , linux-kernel@vger.kernel.org, security@kernel.org Subject: Re: [PATCH] proc: fix races of /proc/PID/{fd/,fdinfo/,fdinfo/*} Message-Id: <20110823144430.75315ce8.akpm@linux-foundation.org> In-Reply-To: <20110804162009.GA2469@albatros> References: <20110804162009.GA2469@albatros> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 4 Aug 2011 20:20:09 +0400 Vasiliy Kulikov wrote: > fd* files are restricted to the task's owner, but keeping opened procfs > file descriptors makes it possible to violate the permission model. > Keeping fdinfo/* may disclosure current position and flags, keeping > fdinfo/ and fd/ may disclosure number of opened files. > > Used existing (un)lock_trace functions to deal with the race. what race. When fixing a bug, please completely, utterly and exhaustively describe the bug! > CC: Stable Tree And when cc'ing -stable, please make it very clear why you consider the bug sufficiently serious to warant mackporting the fix into earlier kernels.