From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755198Ab1HWPTp (ORCPT ); Tue, 23 Aug 2011 11:19:45 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:59661 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754290Ab1HWPTk (ORCPT ); Tue, 23 Aug 2011 11:19:40 -0400 Date: Tue, 23 Aug 2011 16:19:36 +0100 From: Mark Brown To: Tejun Heo , "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: try_to_freeze() called with IRQs disabled on ARM Message-ID: <20110823151936.GM9232@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Cookie: You are always busy. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The recent series of commits reworking the freezer appear to have caused serious issues on ARM. The kernel constantly complains that try_to_freeze() is bring called with interrupts disabled: [ 75.380000] BUG: sleeping function called from invalid context at include/linux/freezer.h:44 [ 75.380000] in_atomic(): 0, irqs_disabled(): 128, pid: 1517, name: Xorg [ 75.380000] no locks held by Xorg/1517. [ 75.380000] [] (unwind_backtrace+0x0/0x12c) from [] (dump_stack+0x20/0x24) [ 75.380000] [] (dump_stack+0x20/0x24) from [] (__might_sleep+0xfc/0x11c) [ 75.380000] [] (__might_sleep+0xfc/0x11c) from [] (do_signal+0x94/0x230) [ 75.380000] [] (do_signal+0x94/0x230) from [] (do_notify_resume+0x28/0x6c) [ 75.380000] [] (do_notify_resume+0x28/0x6c) from [] (work_pending+0x24/0x28) and the boot runs very slowly. Reverting the series merged in 56f0be appears to resolve the issue, though looking at the changes I'd expect there's some underlying bug here that just doesn't trigger very often. I don't really have the bandwidth to understand what's gone wrong right now but should be able to run tests if you've got anything you'd like looking atl.