Re: [PATCH 01/20] drivers_base: platform: use always ->name for uevent

Greg KH
2011-09-30T17:09:26Z

On Fri, Sep 30, 2011 at 04:29:16PM +0300, Felipe Balbi wrote:
> Hi,
>
> On Mon, Aug 15, 2011 at 04:51:22PM +0200, Sebastian Andrzej Siewior wrote:
> > If id_entry is available then it is used. However if we remove first the
> > driver followed by the device, then the id_entry is pointing to driver's
> > memory which is long gone.
> > Since id->name and plat->name are equal there is no point in
> > distinguishing them.
> >
> > Cc: Greg Kroah-Hartman <gregkh@suse.de>
> > Cc: Grant Likely <grant.likely@secretlab.ca>
> > Cc: linux-kernel@vger.kernel.org
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > ---
> > drivers/base/platform.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> > index 0cad9c7..cd71575 100644
> > --- a/drivers/base/platform.c
> > +++ b/drivers/base/platform.c
> > @@ -614,7 +614,7 @@ static int platform_uevent(struct device *dev, struct kobj_uevent_env *env)
> > return rc;
> >
> > add_uevent_var(env, "MODALIAS=%s%s", PLATFORM_MODULE_PREFIX,
> > - (pdev->id_entry) ? pdev->id_entry->name : pdev->name);
> > + pdev->name);
> > return 0;
> > }
> >
>
> Just a gentle reminder on this patch. Greg, has this one been queued to
> your drivers-core tree ? Should it go on -rc or now it's already too
> late and going on merge window ?

It's been in my drivers-core tree for a while, and I didn't think it was
needed for 3.1, as it didn't solve an existing bug, did it?

It's queued for 3.2, does it need to get into 3.1-stable? If so, I can
do that.

thanks,

greg k-h