From: Arnd Bergmann <arnd@arndb.de>
To: Bryan Donlan <bdonlan@gmail.com>
Cc: "Ortwin Glück" <odi@odi.ch>,
linux-kernel@vger.kernel.org,
"Andrew Vasquez" <andrew.vasquez@qlogic.com>,
linux-driver@qlogic.com, linux-scsi@vger.kernel.org
Subject: Re: contention on long-held spinlock
Date: Tue, 23 Aug 2011 18:24:48 +0200 [thread overview]
Message-ID: <201108231824.48512.arnd@arndb.de> (raw)
In-Reply-To: <CAF_S4t_5qfx1H+nm+fvYd24k4ezF__JDFLvg6gv_so8SeVqKvA@mail.gmail.com>
On Friday 19 August 2011, Bryan Donlan wrote:
> That's what mutexes are for. Note, however, that interrupt handlers
> cannot use mutexes as they cannot sleep, nor can they wait for lock
> holders which may themselves sleep.
I agree that there is probably some other bug that needs to be fixed
in the driver, but for testing it may well be worth replacing
the spinlock with a mutex and the request_irq with request_threaded_irq.
A threaded IRQ is slower than a normal one but does allow mutexes.
Arnd
next prev parent reply other threads:[~2011-08-23 16:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 9:21 contention on long-held spinlock Ortwin Glück
2011-08-19 19:25 ` Bryan Donlan
[not found] ` <5E4F49720D0BAD499EE1F01232234BA873C669E4D7@AVEXMB1.qlogic.org>
2011-08-23 15:07 ` Bryan Donlan
2011-08-23 16:24 ` Arnd Bergmann [this message]
2011-08-19 23:30 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108231824.48512.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=andrew.vasquez@qlogic.com \
--cc=bdonlan@gmail.com \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=odi@odi.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox