From: Nishanth Aravamudan <nacc@us.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Fabio M . Di Nitto" <fabbione@fabbione.net>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Alan Cox <alan@lxorguk.ukuu.org.uk>, Greg KH <gregkh@suse.de>
Subject: Re: [PATCH] kernel/printk: do not turn off bootconsole in printk_late_init if keep_bootcon
Date: Tue, 23 Aug 2011 11:41:48 -0700 [thread overview]
Message-ID: <20110823184148.GB3082@us.ibm.com> (raw)
In-Reply-To: <20110819171024.7805dec6.akpm@linux-foundation.org>
Hi Andrew,
On 19.08.2011 [17:10:24 -0700], Andrew Morton wrote:
> On Tue, 9 Aug 2011 17:02:33 -0700
> Nishanth Aravamudan <nacc@us.ibm.com> wrote:
>
> > It seems that commit 7bf693951a8e5f7e600a45b74d91d962a453146e doesn't
> > always achieve what it aims, as printk_late_init() runs it
> > unconditionally turns off all boot consoles. With this patch, I am able
> > to see more messages on the boot console in KVM guests than I can
> > without, when keep_bootcon is specified.
> >
> > Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> > Cc: David S. Miller <davem@davemloft.net>
> > Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> > Cc: Greg KH <gregkh@suse.de>
>
> The patch is applicable to 2.6.39.x and to 3.0.x but I'm unable to work
> out if the end-user impact is sufficiently serious to warrant
> backporting the fix into those kernels.
>
> Please let us know you opinion on this.
Sorry for the delay in responding. I think it is appropriate for the
relevant -stable trees. However, it's more of an annoyance than a
serious bug (ideally you don't need to keep the boot console around as
console handover should be working -- I was encountering a situation
where the console handover wasn't working and not having the boot
console available meant I couldn't see why).
Thanks,
Nish
--
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center
prev parent reply other threads:[~2011-08-23 18:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 0:02 [PATCH] kernel/printk: do not turn off bootconsole in printk_late_init if keep_bootcon Nishanth Aravamudan
2011-08-15 12:03 ` Fabio M. Di Nitto
2011-08-20 0:10 ` Andrew Morton
2011-08-23 18:41 ` Nishanth Aravamudan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110823184148.GB3082@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=fabbione@fabbione.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox