From: Greg KH <greg@kroah.com>
To: Mark Einon <mark.einon@gmail.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, o.hartmann@telovital.com
Subject: Re: [PATCH 5/5] staging: et131x: Fix free IRQ from IRQ context warning after tx_timeout
Date: Tue, 23 Aug 2011 11:50:20 -0700 [thread overview]
Message-ID: <20110823185020.GA11302@kroah.com> (raw)
In-Reply-To: <1312321621-2695-1-git-send-email-mark.einon@gmail.com>
On Tue, Aug 02, 2011 at 10:47:01PM +0100, Mark Einon wrote:
> When a tx timeout occured, et131x_tx_timeout closed and re-opened the device to fix.
> As et131x_close called free_irq(), bad things ensued (see warning trace below), namely a
> storm of errors and warnings.
> Fixed by replacing the close() and open() calls with just the relevant functions previously
> called from these.
> Verified on an ET-1310 device.
>
> Signed-off-by: Mark Einon <mark.einon@gmail.com>
This patch breaks the build :(
Care to resend this one, and any other patch you have sent me but I
didn't apply yet, again, as I have now applied all et131x patches in my
queue.
thanks,
greg k-h
next prev parent reply other threads:[~2011-08-23 18:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 21:47 [PATCH 5/5] staging: et131x: Fix free IRQ from IRQ context warning after tx_timeout Mark Einon
2011-08-23 18:50 ` Greg KH [this message]
2011-08-23 20:43 ` Mark Einon
2011-08-23 21:03 ` Greg KH
2011-08-23 21:07 ` Mark Einon
2011-08-23 22:40 ` [PATCH 0/8] [RESEND] staging: et131x: Code cleanups Mark Einon
2011-08-23 22:40 ` [PATCH 1/8] [RESEND] staging: et131x: Remove unecessary *etdev NULL check in et1310_phy_init() Mark Einon
2011-08-23 22:40 ` [PATCH 2/8] [RESEND] staging: et131x: Converting et1310_tx.c function and local names from CamelCase Mark Einon
2011-08-23 22:40 ` [PATCH 3/8] [RESEND] staging: et131x: Converting et1310_adapter.h variable " Mark Einon
2011-08-23 22:40 ` [PATCH 4/8] [RESEND] staging: et131x: Removing commented out code implemented elsewhere Mark Einon
2011-08-23 22:40 ` [PATCH 5/8] [RESEND] staging: et131x: Rename var name 'etdev' to 'adapter' throughout module Mark Einon
2011-08-23 22:40 ` [PATCH 6/8] [RESEND] staging: et131x: Fix link detection signalling Mark Einon
2011-08-23 22:40 ` [PATCH 7/8] [RESEND] staging: et131x: Fix free IRQ from IRQ context warning after tx_timeout Mark Einon
2011-08-23 22:40 ` [PATCH 8/8] staging: et131x: Update tx trans_start on device close to prevent tx_timeout Mark Einon
2011-08-23 23:25 ` [PATCH 0/8] [RESEND] staging: et131x: Code cleanups Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110823185020.GA11302@kroah.com \
--to=greg@kroah.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.einon@gmail.com \
--cc=o.hartmann@telovital.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox