public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] staging: comedi: changed local function prototype from extern to static.
@ 2011-08-22 10:39 Pelle Windestam
  2011-08-23 18:57 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Pelle Windestam @ 2011-08-22 10:39 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: devel, linux-kernel, Pelle Windestam

Changed local function prototype do_become_nonbusy(...) from extern to
static, fixing the error from checkpatch.pl.

Signed-off-by: Pelle Windestam <iceaway@gmail.com>
---
 drivers/staging/comedi/comedi_fops.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index e90e3cc..d7b6a28 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -101,7 +101,7 @@ static int do_insn_ioctl(struct comedi_device *dev,
 static int do_poll_ioctl(struct comedi_device *dev, unsigned int subd,
 			 void *file);
 
-extern void do_become_nonbusy(struct comedi_device *dev,
+static void do_become_nonbusy(struct comedi_device *dev,
 			      struct comedi_subdevice *s);
 static int do_cancel(struct comedi_device *dev, struct comedi_subdevice *s);
 
@@ -1786,7 +1786,8 @@ done:
 /*
    This function restores a subdevice to an idle state.
  */
-void do_become_nonbusy(struct comedi_device *dev, struct comedi_subdevice *s)
+static void do_become_nonbusy(struct comedi_device *dev,
+			      struct comedi_subdevice *s)
 {
 	struct comedi_async *async = s->async;
 
-- 
1.7.3.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] staging: comedi: changed local function prototype from extern to static.
  2011-08-22 10:39 [PATCH 1/1] staging: comedi: changed local function prototype from extern to static Pelle Windestam
@ 2011-08-23 18:57 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2011-08-23 18:57 UTC (permalink / raw)
  To: Pelle Windestam; +Cc: Greg Kroah-Hartman, devel, linux-kernel

On Mon, Aug 22, 2011 at 12:39:45PM +0200, Pelle Windestam wrote:
> Changed local function prototype do_become_nonbusy(...) from extern to
> static, fixing the error from checkpatch.pl.
> 
> Signed-off-by: Pelle Windestam <iceaway@gmail.com>

Sorry, someone just beat you to this same change :(


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-23 19:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-22 10:39 [PATCH 1/1] staging: comedi: changed local function prototype from extern to static Pelle Windestam
2011-08-23 18:57 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox