* [PATCH] staging: IIO: DAC: Delete useless label error_ret in ad5791.c
@ 2011-08-06 18:09 stufever
2011-08-12 8:51 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: stufever @ 2011-08-06 18:09 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-iio, gregkh, michael.hennerich, Wang Shaoyan
From: Wang Shaoyan <wangshaoyan.pt@taobao.com>
drivers/staging/iio/dac/ad5791.c: In function 'ad5791_probe':
drivers/staging/iio/dac/ad5791.c:384: warning: label 'error_ret' defined but not used
The label error_ret is defined, but never used, so delete it to avoid annoying warning.
Signed-off-by: Wang Shaoyan <wangshaoyan.pt@taobao.com>
---
drivers/staging/iio/dac/ad5791.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/iio/dac/ad5791.c b/drivers/staging/iio/dac/ad5791.c
index 64770d2..5b00b70 100644
--- a/drivers/staging/iio/dac/ad5791.c
+++ b/drivers/staging/iio/dac/ad5791.c
@@ -381,7 +381,6 @@ error_put_reg_pos:
if (!IS_ERR(reg_vdd))
regulator_put(reg_vdd);
-error_ret:
return ret;
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: IIO: DAC: Delete useless label error_ret in ad5791.c
2011-08-06 18:09 [PATCH] staging: IIO: DAC: Delete useless label error_ret in ad5791.c stufever
@ 2011-08-12 8:51 ` Jonathan Cameron
2011-08-12 14:21 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Cameron @ 2011-08-12 8:51 UTC (permalink / raw)
To: stufever; +Cc: linux-kernel, linux-iio, gregkh, michael.hennerich, Wang Shaoyan
On 08/06/11 19:09, stufever@gmail.com wrote:
> From: Wang Shaoyan <wangshaoyan.pt@taobao.com>
>
> drivers/staging/iio/dac/ad5791.c: In function 'ad5791_probe':
> drivers/staging/iio/dac/ad5791.c:384: warning: label 'error_ret' defined but not used
>
> The label error_ret is defined, but never used, so delete it to avoid annoying warning.
As with other one, this is fixed in iio-blue.git, but I'm happy to see either version merge.
>
> Signed-off-by: Wang Shaoyan <wangshaoyan.pt@taobao.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
> ---
> drivers/staging/iio/dac/ad5791.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/iio/dac/ad5791.c b/drivers/staging/iio/dac/ad5791.c
> index 64770d2..5b00b70 100644
> --- a/drivers/staging/iio/dac/ad5791.c
> +++ b/drivers/staging/iio/dac/ad5791.c
> @@ -381,7 +381,6 @@ error_put_reg_pos:
> if (!IS_ERR(reg_vdd))
> regulator_put(reg_vdd);
>
> -error_ret:
> return ret;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: IIO: DAC: Delete useless label error_ret in ad5791.c
2011-08-12 8:51 ` Jonathan Cameron
@ 2011-08-12 14:21 ` Jonathan Cameron
2011-08-23 20:39 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Cameron @ 2011-08-12 14:21 UTC (permalink / raw)
To: Jonathan Cameron
Cc: stufever, linux-kernel, linux-iio, gregkh, michael.hennerich,
Wang Shaoyan
On 08/12/11 09:51, Jonathan Cameron wrote:
> On 08/06/11 19:09, stufever@gmail.com wrote:
>> From: Wang Shaoyan <wangshaoyan.pt@taobao.com>
>>
>> drivers/staging/iio/dac/ad5791.c: In function 'ad5791_probe':
>> drivers/staging/iio/dac/ad5791.c:384: warning: label 'error_ret' defined but not used
>>
>> The label error_ret is defined, but never used, so delete it to avoid annoying warning.
> As with other one, this is fixed in iio-blue.git, but I'm happy to see either version merge.
I'm dozing. This is the third fix for this one. Greg, pick up which ever one you want!
>>
>> Signed-off-by: Wang Shaoyan <wangshaoyan.pt@taobao.com>
> Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
>> ---
>> drivers/staging/iio/dac/ad5791.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/staging/iio/dac/ad5791.c b/drivers/staging/iio/dac/ad5791.c
>> index 64770d2..5b00b70 100644
>> --- a/drivers/staging/iio/dac/ad5791.c
>> +++ b/drivers/staging/iio/dac/ad5791.c
>> @@ -381,7 +381,6 @@ error_put_reg_pos:
>> if (!IS_ERR(reg_vdd))
>> regulator_put(reg_vdd);
>>
>> -error_ret:
>> return ret;
>> }
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: IIO: DAC: Delete useless label error_ret in ad5791.c
2011-08-12 14:21 ` Jonathan Cameron
@ 2011-08-23 20:39 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2011-08-23 20:39 UTC (permalink / raw)
To: Jonathan Cameron
Cc: stufever, linux-kernel, linux-iio, gregkh, michael.hennerich,
Wang Shaoyan
On Fri, Aug 12, 2011 at 03:21:50PM +0100, Jonathan Cameron wrote:
> On 08/12/11 09:51, Jonathan Cameron wrote:
> > On 08/06/11 19:09, stufever@gmail.com wrote:
> >> From: Wang Shaoyan <wangshaoyan.pt@taobao.com>
> >>
> >> drivers/staging/iio/dac/ad5791.c: In function 'ad5791_probe':
> >> drivers/staging/iio/dac/ad5791.c:384: warning: label 'error_ret' defined but not used
> >>
> >> The label error_ret is defined, but never used, so delete it to avoid annoying warning.
> > As with other one, this is fixed in iio-blue.git, but I'm happy to see either version merge.
> I'm dozing. This is the third fix for this one. Greg, pick up which ever one you want!
It's now resolved in my tree.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-08-23 20:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-06 18:09 [PATCH] staging: IIO: DAC: Delete useless label error_ret in ad5791.c stufever
2011-08-12 8:51 ` Jonathan Cameron
2011-08-12 14:21 ` Jonathan Cameron
2011-08-23 20:39 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox