From: Frederic Weisbecker <fweisbec@gmail.com>
To: Tejun Heo <tj@kernel.org>, Andrew Morton <akpm@linux-foundation.org>
Cc: rjw@sisk.pl, paul@paulmenage.org, lizf@cn.fujitsu.com,
linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org
Subject: Re: [PATCH 1/6] cgroup: subsys->attach_task() should be called after migration
Date: Wed, 24 Aug 2011 02:32:36 +0200 [thread overview]
Message-ID: <20110824003234.GB23979@somewhere> (raw)
In-Reply-To: <1314138000-2049-2-git-send-email-tj@kernel.org>
On Wed, Aug 24, 2011 at 12:19:55AM +0200, Tejun Heo wrote:
> cgroup_attach_task() calls subsys->attach_task() after
> cgroup_task_migrate(); however, cgroup_attach_proc() calls it before
> migration. This actually affects some of the users. Update
> cgroup_attach_proc() such that ->attach_task() is called after
> migration.
There have been a patch posted recently:
"[PATCH][BUGFIX] cgroups: fix ordering of calls in cgroup_attach_proc"
that not only fixes that ordering but also only attach the task if the
migration happened correctly (task not exited).
Can somebody queue it for 3.2 ?
next prev parent reply other threads:[~2011-08-24 0:32 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 22:19 [PATCHSET] cgroup: introduce cgroup_taskset and consolidate subsys methods Tejun Heo
2011-08-23 22:19 ` [PATCH 1/6] cgroup: subsys->attach_task() should be called after migration Tejun Heo
2011-08-24 0:32 ` Frederic Weisbecker [this message]
2011-08-24 1:31 ` Li Zefan
2011-08-23 22:19 ` [PATCH 2/6] cgroup: improve old cgroup handling in cgroup_attach_proc() Tejun Heo
2011-08-25 8:51 ` Paul Menage
2011-08-25 9:03 ` Tejun Heo
2011-08-25 9:42 ` Paul Menage
2011-08-25 9:44 ` Tejun Heo
2011-08-23 22:19 ` [PATCH 3/6] cgroup: introduce cgroup_taskset and use it in subsys->can_attach(), cancel_attach() and attach() Tejun Heo
2011-08-25 0:39 ` KAMEZAWA Hiroyuki
2011-08-25 8:20 ` Tejun Heo
2011-08-25 8:21 ` KAMEZAWA Hiroyuki
2011-08-25 8:40 ` Tejun Heo
2011-08-25 8:37 ` KAMEZAWA Hiroyuki
2011-08-25 9:14 ` Paul Menage
2011-08-25 9:20 ` Tejun Heo
2011-08-25 9:32 ` Paul Menage
2011-08-25 9:32 ` Paul Menage
2011-08-23 22:19 ` [PATCH 4/6] cgroup: don't use subsys->can_attach_task() or ->attach_task() Tejun Heo
2011-08-24 1:57 ` Matt Helsley
2011-08-24 7:54 ` Tejun Heo
2011-08-25 9:07 ` Paul Menage
2011-08-25 9:12 ` Tejun Heo
2011-08-23 22:19 ` [PATCH 5/6] cgroup, cpuset: don't use ss->pre_attach() Tejun Heo
2011-08-25 8:53 ` Paul Menage
2011-08-25 9:06 ` Tejun Heo
2011-08-23 22:20 ` [PATCH 6/6] cgroup: kill subsys->can_attach_task(), pre_attach() and attach_task() Tejun Heo
2011-08-25 9:45 ` Paul Menage
2011-08-24 1:14 ` [PATCHSET] cgroup: introduce cgroup_taskset and consolidate subsys methods Frederic Weisbecker
2011-08-24 7:49 ` Tejun Heo
2011-08-24 13:53 ` Frederic Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2011-08-25 22:43 [PATCHSET] cgroup: introduce cgroup_taskset and consolidate subsys methods, take#2 Tejun Heo
2011-08-25 22:43 ` [PATCH 1/6] cgroup: subsys->attach_task() should be called after migration Tejun Heo
2011-08-26 4:12 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110824003234.GB23979@somewhere \
--to=fweisbec@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=lizf@cn.fujitsu.com \
--cc=paul@paulmenage.org \
--cc=rjw@sisk.pl \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox