From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752834Ab1HXRja (ORCPT ); Wed, 24 Aug 2011 13:39:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50005 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752671Ab1HXRj1 (ORCPT ); Wed, 24 Aug 2011 13:39:27 -0400 Date: Wed, 24 Aug 2011 19:36:27 +0200 From: Oleg Nesterov To: Matt Fleming Cc: linux-kernel@vger.kernel.org, Petr Vandrovec , Al Viro , Arnd Bergmann Subject: Re: [PATCH v2 43/43] ncpfs: Use set_current_blocked() Message-ID: <20110824173627.GA18904@redhat.com> References: <1313772419-21951-1-git-send-email-matt@console-pimps.org> <1313772419-21951-44-git-send-email-matt@console-pimps.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1313772419-21951-44-git-send-email-matt@console-pimps.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/19, Matt Fleming wrote: > > From: Matt Fleming > > As described in e6fa16ab ("signal: sigprocmask() should do > retarget_shared_pending()") the modification of current->blocked is > incorrect as we need to check whether the signal we're about to block > is pending in the shared queue. > > Also, there's no need to hold sighand->siglock while reading > sighand->action[] because the lock is dropped across the call to > do_ncp_rpc_call() during which time another thread could modify > ->action[]. Unlless you object, I am going to add the following into the changelog: Note: the current code does the strange things which nobody can explain, especially the PF_EXITING/SIGKILL thing. This patch does try to change this. and push the patch into ptrace branch. Oleg.