* [PATCH] staging/olpc_dcon: Remove obsolete cleanup for clientdata
@ 2011-08-25 10:53 Wolfram Sang
2011-08-25 11:04 ` Jean Delvare
2011-08-25 14:45 ` Andres Salomon
0 siblings, 2 replies; 3+ messages in thread
From: Wolfram Sang @ 2011-08-25 10:53 UTC (permalink / raw)
To: linux-i2c
Cc: Wolfram Sang, Greg Kroah-Hartman, Andres Salomon, Andrew Morton,
Marek Belisko, Jean Delvare, devel, linux-kernel
A few new i2c-drivers came into the kernel which clear the clientdata-pointer
on exit or error. This is obsolete meanwhile, the core will do it.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Andres Salomon <dilinger@queued.net>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Marek Belisko <marek.belisko@open-nandra.com>
Cc: Jean Delvare <khali@linux-fr.org>
---
drivers/staging/olpc_dcon/olpc_dcon.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
index 750fe50..a235330 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon.c
+++ b/drivers/staging/olpc_dcon/olpc_dcon.c
@@ -712,7 +712,6 @@ static int dcon_probe(struct i2c_client *client, const struct i2c_device_id *id)
eirq:
free_irq(DCON_IRQ, dcon);
einit:
- i2c_set_clientdata(client, NULL);
kfree(dcon);
return rc;
}
@@ -721,8 +720,6 @@ static int dcon_remove(struct i2c_client *client)
{
struct dcon_priv *dcon = i2c_get_clientdata(client);
- i2c_set_clientdata(client, NULL);
-
fb_unregister_client(&dcon->fbevent_nb);
unregister_reboot_notifier(&dcon->reboot_nb);
atomic_notifier_chain_unregister(&panic_notifier_list, &dcon_panic_nb);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging/olpc_dcon: Remove obsolete cleanup for clientdata
2011-08-25 10:53 [PATCH] staging/olpc_dcon: Remove obsolete cleanup for clientdata Wolfram Sang
@ 2011-08-25 11:04 ` Jean Delvare
2011-08-25 14:45 ` Andres Salomon
1 sibling, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2011-08-25 11:04 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, Greg Kroah-Hartman, Andres Salomon, Andrew Morton,
Marek Belisko, devel, linux-kernel
On Thu, 25 Aug 2011 12:53:30 +0200, Wolfram Sang wrote:
> A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> on exit or error. This is obsolete meanwhile, the core will do it.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Cc: Andres Salomon <dilinger@queued.net>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Marek Belisko <marek.belisko@open-nandra.com>
> Cc: Jean Delvare <khali@linux-fr.org>
> ---
> drivers/staging/olpc_dcon/olpc_dcon.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
> index 750fe50..a235330 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -712,7 +712,6 @@ static int dcon_probe(struct i2c_client *client, const struct i2c_device_id *id)
> eirq:
> free_irq(DCON_IRQ, dcon);
> einit:
> - i2c_set_clientdata(client, NULL);
> kfree(dcon);
> return rc;
> }
> @@ -721,8 +720,6 @@ static int dcon_remove(struct i2c_client *client)
> {
> struct dcon_priv *dcon = i2c_get_clientdata(client);
>
> - i2c_set_clientdata(client, NULL);
> -
> fb_unregister_client(&dcon->fbevent_nb);
> unregister_reboot_notifier(&dcon->reboot_nb);
> atomic_notifier_chain_unregister(&panic_notifier_list, &dcon_panic_nb);
Acked-by: Jean Delvare <khali@linux-fr.org>
--
Jean Delvare
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging/olpc_dcon: Remove obsolete cleanup for clientdata
2011-08-25 10:53 [PATCH] staging/olpc_dcon: Remove obsolete cleanup for clientdata Wolfram Sang
2011-08-25 11:04 ` Jean Delvare
@ 2011-08-25 14:45 ` Andres Salomon
1 sibling, 0 replies; 3+ messages in thread
From: Andres Salomon @ 2011-08-25 14:45 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, Greg Kroah-Hartman, Andrew Morton, Marek Belisko,
Jean Delvare, devel, linux-kernel
Thanks!
Acked-by: Andres Salomon <dilinger@queued.net>
On Thu, 25 Aug 2011 12:53:30 +0200
Wolfram Sang <w.sang@pengutronix.de> wrote:
> A few new i2c-drivers came into the kernel which clear the
> clientdata-pointer on exit or error. This is obsolete meanwhile, the
> core will do it.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Cc: Andres Salomon <dilinger@queued.net>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Marek Belisko <marek.belisko@open-nandra.com>
> Cc: Jean Delvare <khali@linux-fr.org>
> ---
> drivers/staging/olpc_dcon/olpc_dcon.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c
> b/drivers/staging/olpc_dcon/olpc_dcon.c index 750fe50..a235330 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -712,7 +712,6 @@ static int dcon_probe(struct i2c_client *client,
> const struct i2c_device_id *id) eirq:
> free_irq(DCON_IRQ, dcon);
> einit:
> - i2c_set_clientdata(client, NULL);
> kfree(dcon);
> return rc;
> }
> @@ -721,8 +720,6 @@ static int dcon_remove(struct i2c_client *client)
> {
> struct dcon_priv *dcon = i2c_get_clientdata(client);
>
> - i2c_set_clientdata(client, NULL);
> -
> fb_unregister_client(&dcon->fbevent_nb);
> unregister_reboot_notifier(&dcon->reboot_nb);
> atomic_notifier_chain_unregister(&panic_notifier_list,
> &dcon_panic_nb);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-25 14:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-25 10:53 [PATCH] staging/olpc_dcon: Remove obsolete cleanup for clientdata Wolfram Sang
2011-08-25 11:04 ` Jean Delvare
2011-08-25 14:45 ` Andres Salomon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox