From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: RFC: Remove unnecessary / duplicate OOM printks
Date: Thu, 25 Aug 2011 15:04:56 -0700 [thread overview]
Message-ID: <20110825150456.fc8720c4.akpm@linux-foundation.org> (raw)
In-Reply-To: <1314305243.4637.10.camel@Joe-Laptop>
On Thu, 25 Aug 2011 13:47:23 -0700
Joe Perches <joe@perches.com> wrote:
> There are many thousands of printks for OOM conditions
> in kernel sources.
>
> These are almost always a duplication of a generic
> OOM message from the mm subsystem.
>
> The biggest difference between the generic OOM and
> the specific OOM uses is that most of the specific
> messages are emitted at KERN_ERR but the generic
> message is at KERN_WARNING.
>
> Many KB of code/text could be removed from the kernel.
>
> Removal can be gradual and done by subsystem.
>
> Some kmalloc's that are followed on failure by vmalloc
> may need to add GFP_NOWARN.
>
> Does anyone really believe the per site failure
> messages are useful or really want them to keep them?
>
Kill 'em.
next prev parent reply other threads:[~2011-08-25 22:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 20:47 RFC: Remove unnecessary / duplicate OOM printks Joe Perches
2011-08-25 22:04 ` Andrew Morton [this message]
2011-08-25 23:22 ` [RFC PATCH] caif: Remove OOM messages, use kzalloc Joe Perches
2011-08-28 21:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110825150456.fc8720c4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox