From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: "mingo@elte.hu" <mingo@elte.hu>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"hpa@zytor.com" <hpa@zytor.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"yinghai@kernel.org" <yinghai@kernel.org>,
"Song, Youquan" <youquan.song@intel.com>,
"Luck, Tony" <tony.luck@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [patch 3/8] iommu: move IOMMU specific code to intel-iommu.c
Date: Thu, 25 Aug 2011 19:05:34 +0200 [thread overview]
Message-ID: <20110825170534.GL1923@amd.com> (raw)
In-Reply-To: <1314210701.16133.13.camel@sbsiddha-desk.sc.intel.com>
On Wed, Aug 24, 2011 at 02:31:40PM -0400, Suresh Siddha wrote:
> On Wed, 2011-08-24 at 02:27 -0700, Roedel, Joerg wrote:
> > On Tue, Aug 23, 2011 at 08:05:20PM -0400, Suresh Siddha wrote:
> > > +static void __init dmar_register_rmrr_unit(struct dmar_rmrr_unit *rmrr)
> > > +int __init dmar_parse_one_rmrr(struct acpi_dmar_header *header)
> > > +int __init dmar_parse_one_atsr(struct acpi_dmar_header *hdr)
> > > +int dmar_find_matched_atsr_unit(struct pci_dev *dev)
> > > +int dmar_parse_rmrr_atsr_dev(void)
> >
> > If these functions are not DMAR specific, how about replacing the dmar_
> > prefix too while at it?
>
> These parsing functions are APCI DMAR table specific and are used only
> by intel-iommu routines. Because of this I didn't change their names but
> just moved to intel-iommu.c to cleanup some of the ifdef's in the common
> dmar.c code (specific to handling common ACPI DMAR tables etc) shared by
> both DMA-remapping (iommu) and IRQ-remapping.
Okay, should be fine then.
Thanks,
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2011-08-25 17:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 0:05 [patch 0/8] intel iommu, irq-remap, x2apic bug fixes and cleanups Suresh Siddha
2011-08-24 0:05 ` [patch 1/8] x86, x2apic: enable the bios request for x2apic optout Suresh Siddha
2011-08-24 0:05 ` [patch 2/8] intr_remap: call dmar_dev_scope_init() explicitly Suresh Siddha
2011-08-24 0:05 ` [patch 3/8] iommu: move IOMMU specific code to intel-iommu.c Suresh Siddha
2011-08-24 9:27 ` Roedel, Joerg
2011-08-24 18:31 ` Suresh Siddha
2011-08-25 17:05 ` Roedel, Joerg [this message]
2011-08-24 0:05 ` [patch 4/8] iommu: no need to set dmar_disabled in check_zero_address() Suresh Siddha
2011-08-24 0:05 ` [patch 5/8] iommu: cleanup ifdefs in detect_intel_iommu() Suresh Siddha
2011-08-24 0:05 ` [patch 6/8] x86, msi, intr-remap: use the ioapic set affinity routine Suresh Siddha
2011-08-24 6:57 ` Yinghai Lu
2011-08-24 0:05 ` [patch 7/8] x86, ioapic: define irq_remap_modify_chip_defaults() Suresh Siddha
2011-08-24 0:05 ` [patch 8/8] iommu: rename the DMAR and INTR_REMAP config options Suresh Siddha
2011-08-24 6:47 ` Yinghai Lu
2011-08-24 8:28 ` Roedel, Joerg
2011-08-24 18:25 ` Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110825170534.GL1923@amd.com \
--to=joerg.roedel@amd.com \
--cc=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=yinghai@kernel.org \
--cc=youquan.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox