From: "Michael S. Tsirkin" <mst@redhat.com>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Alex Williamson <alex.williamson@redhat.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Matthew Wilcox <matthew@wil.cx>
Subject: Re: Broken pci_block_user_cfg_access interface
Date: Thu, 25 Aug 2011 21:16:13 +0300 [thread overview]
Message-ID: <20110825181613.GA27183@redhat.com> (raw)
In-Reply-To: <4E564CF9.5070209@linux.vnet.ibm.com>
On Thu, Aug 25, 2011 at 08:24:09AM -0500, Brian King wrote:
> > Is this broken ATM? I thought the PCI core would simply try all methods
> > + has a quirks section for completely funky devices.
>
> Yes. Its certainly broken for ipr. If the ipr driver is loaded, it really needs
> to be the one doing the reset. If its not loaded, I may need to add a few
> quirks for these adapters to properly handle this function.
>
> -Brian
Driving reset through sysfs while another driver is bound
is likely broken for many types of devices.
But so it writing config space through sysfs,
or accessing BARs by mmap while a kernel driver is bound
with the exception of simple stub drivers such as uio and pci-stub.
And no amount of locking can fix that I think.
Let's try to see whether there's an issue with
existing applications, all of which IIUC
have a single userspace driver accessing the device.
Besides that, all we need to address, as I see it,
is not making things worse: that is if device potentially
gets broken by a sysfs access, we can't help this,
but let's at least not trigger BUG errors.
--
MST
next prev parent reply other threads:[~2011-08-25 18:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 10:43 Broken pci_block_user_cfg_access interface Jan Kiszka
2011-08-24 15:02 ` Brian King
2011-08-25 9:19 ` Jan Kiszka
2011-08-25 9:40 ` Michael S. Tsirkin
2011-08-25 10:34 ` Jan Kiszka
2011-08-25 13:06 ` Brian King
2011-08-25 13:12 ` Brian King
2011-08-25 13:16 ` Jan Kiszka
2011-08-25 13:24 ` Brian King
2011-08-25 18:16 ` Michael S. Tsirkin [this message]
2011-08-25 13:02 ` Brian King
2011-08-25 13:06 ` Jan Kiszka
2011-08-25 18:19 ` Michael S. Tsirkin
2011-08-25 18:52 ` Jan Kiszka
2011-08-25 19:07 ` Michael S. Tsirkin
2011-08-25 19:26 ` Jan Kiszka
2011-08-29 15:05 ` Michael S. Tsirkin
2011-08-29 15:42 ` Jan Kiszka
2011-08-29 15:58 ` Michael S. Tsirkin
2011-08-29 16:14 ` Jan Kiszka
2011-08-29 16:23 ` Michael S. Tsirkin
2011-08-29 16:26 ` Jan Kiszka
2011-08-29 18:47 ` Jan Kiszka
2011-08-29 19:18 ` Michael S. Tsirkin
2011-08-30 16:30 ` Brian King
2011-08-30 18:01 ` Michael S. Tsirkin
2011-08-30 19:41 ` Brian King
2011-09-02 7:48 ` [RFC] pci: Rework config space blocking services Jan Kiszka
2011-09-06 7:00 ` Michael S. Tsirkin
2011-09-06 7:18 ` Jan Kiszka
2011-09-06 8:04 ` Michael S. Tsirkin
2011-09-06 8:27 ` Jan Kiszka
2011-09-06 8:47 ` Michael S. Tsirkin
2011-09-06 8:48 ` Jan Kiszka
2011-09-07 13:46 ` Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110825181613.GA27183@redhat.com \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=brking@linux.vnet.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox