From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755277Ab1HYSs3 (ORCPT ); Thu, 25 Aug 2011 14:48:29 -0400 Received: from out3.smtp.messagingengine.com ([66.111.4.27]:33029 "EHLO out3.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754273Ab1HYSs2 (ORCPT ); Thu, 25 Aug 2011 14:48:28 -0400 X-Sasl-enc: cjNphzRaLcmK+Dt6W0xso28OODPuxKS/T+eBeTh7llvH 1314298107 Date: Thu, 25 Aug 2011 11:46:12 -0700 From: Greg KH To: KY Srinivasan Cc: "gregkh@suse.de" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "virtualization@lists.osdl.org" , Haiyang Zhang Subject: Re: [PATCH 06/59] Staging: hv: blkvsc: Use the newly introduced vmbus ID in the blockvsc driver Message-ID: <20110825184612.GA1891@kroah.com> References: <1314290866-2644-1-git-send-email-kys@microsoft.com> <1314290965-2698-1-git-send-email-kys@microsoft.com> <1314290965-2698-6-git-send-email-kys@microsoft.com> <20110825173624.GA21334@kroah.com> <6E21E5352C11B742B20C142EB499E048081B339F@TK5EX14MBXC126.redmond.corp.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6E21E5352C11B742B20C142EB499E048081B339F@TK5EX14MBXC126.redmond.corp.microsoft.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 25, 2011 at 05:52:10PM +0000, KY Srinivasan wrote: > > No need to set the field name to nothing. > > > > Hm, this could all be made even smaller with something like the > > USB_DEVICE() macro. How about this instead: > > > > /* IDE guid */ > > static const struct hv_vmbus_device_id id_table[] = { > > { VMBUS_DEVICE(0x32, 0x26, 0x41, 0x32, 0xcb, 0x86, 0xa2, 0x44, > > 0x9b, 0x5c, 0x50, 0xd1, 0x41, 0x73, 0x54, 0xf5) }, > > { }, > > }; > > > > That would be easier to read and understand, right? Half the number of > > lines as well, which is always nice. > > > > If so, I'll go make that change here so you don't have to respin these. > > Looks great Greg. So you are going to add the VMBUS_DEVICE() macro? Yes, I've now done so and pushed out the changes, which you have been copied on, including a bug fix that I needed to make when I added the driver_data field to the hv_vmbus_device_id structure. I'll review the rest of the series after lunch. thanks, greg k-h