From: Andrew Morton <akpm@linux-foundation.org>
To: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Cc: Greg KH <gregkh@suse.de>, Kay Sievers <kay.sievers@vrfy.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org, Nick Piggin <npiggin@kernel.dk>,
Al Viro <viro@zeniv.linux.org.uk>, Christoph Hellwig <hch@lst.de>,
Stephen Rothwell <sfr@canb.auug.org.au>,
David Howells <dhowells@redhat.com>,
"Serge E. Hallyn" <serge.hallyn@canonical.com>,
Daniel Lezcano <daniel.lezcano@free.fr>,
Jiri Slaby <jslaby@suse.cz>, James Morris <jmorris@namei.org>,
neilb@suse.de
Subject: Re: [PATCH] sysctl: add support for poll()
Date: Fri, 26 Aug 2011 14:06:10 -0700 [thread overview]
Message-ID: <20110826140610.c4d27e1a.akpm@linux-foundation.org> (raw)
In-Reply-To: <1312484238-1645-1-git-send-email-lucas.demarchi@profusion.mobi>
On Thu, 4 Aug 2011 15:57:18 -0300
Lucas De Marchi <lucas.demarchi@profusion.mobi> wrote:
> Adding support for poll() in sysctl fs allows userspace to receive
> notifications of changes in sysctl entries. This adds a infrastructure
> to allow files in sysctl fs to be pollable and implements it for
> hostname and domainname.
>
Seems reasonable. One slight nit:
> +#define __CTL_TABLE_POLL_INITIALIZER(name) { \
> + .event = ATOMIC_INIT(0), \
> + .wait = __WAIT_QUEUE_HEAD_INITIALIZER(name.wait) }
> +
> +#define DECLARE_CTL_TABLE_POLL(name) \
> + struct ctl_table_poll name = __CTL_TABLE_POLL_INITIALIZER(name)
This macro is used to define an instance of ctl_table_poll. Hence it
should be called DEFINE_CTL_TABLE_POLL, not DECLARE_*.
declaration: "one of these exists"
definition: "here it is".
This matters a bit, because sometimes we'll have separate macros for
declaring and defining.
next prev parent reply other threads:[~2011-08-26 21:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 12:14 [PATCH] sysctl: add support for poll() Lucas De Marchi
2011-06-02 2:51 ` Lucas De Marchi
2011-06-02 3:31 ` Eric W. Biederman
2011-06-02 12:06 ` Kay Sievers
2011-06-02 12:43 ` Alan Cox
2011-06-02 13:01 ` Kay Sievers
2011-06-02 13:02 ` Lucas De Marchi
2011-06-02 13:12 ` Alan Cox
2011-06-02 13:24 ` Kay Sievers
2011-06-02 13:56 ` Eric W. Biederman
2011-06-02 17:32 ` Kay Sievers
2011-06-08 22:17 ` Andrew Morton
2011-06-09 13:16 ` Kay Sievers
2011-06-13 16:05 ` Kay Sievers
2011-06-14 3:53 ` Lucas De Marchi
2011-06-14 4:17 ` NeilBrown
2011-07-26 2:17 ` Lucas De Marchi
2011-08-02 22:53 ` Kay Sievers
2011-08-02 23:16 ` Greg KH
2011-08-03 1:12 ` Lucas De Marchi
2011-08-03 9:40 ` Eric W. Biederman
2011-08-03 13:17 ` Lucas De Marchi
2011-08-03 18:08 ` Eric W. Biederman
2011-08-03 18:45 ` Lucas De Marchi
2011-08-04 18:57 ` Lucas De Marchi
2011-08-23 17:57 ` Greg KH
2011-08-26 21:06 ` Andrew Morton [this message]
2011-06-12 15:34 ` Eric W. Biederman
2011-06-13 14:28 ` Kay Sievers
2011-06-02 14:16 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110826140610.c4d27e1a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=daniel.lezcano@free.fr \
--cc=dhowells@redhat.com \
--cc=gregkh@suse.de \
--cc=hch@lst.de \
--cc=jmorris@namei.org \
--cc=jslaby@suse.cz \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=neilb@suse.de \
--cc=npiggin@kernel.dk \
--cc=serge.hallyn@canonical.com \
--cc=sfr@canb.auug.org.au \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox