Re: [Drbd-dev] [RFC 000/118] drbd: part 1 of adding multiple volume support to drbd

Kyle Moffett
2011-08-26T15:19:15Z

On Fri, Aug 26, 2011 at 09:54, Lars Ellenberg <lars.ellenberg@linbit.com> wrote:
> On Fri, Aug 26, 2011 at 09:20:51AM -0400, Greg Freemyer wrote:
>> On Thu, Aug 25, 2011 at 11:06 AM, Philipp Reisner <
>> philipp.reisner@linbit.com> wrote:
>>
>> > This the first request for review of drbd-8.4. The complete set has
>> > 500 patches. In this first series there are only 118 of these.
>>
>> I've only taken a quick glance, but is drbd functional between applying each
>> patch?
>>
>> It doesn't look like it to me, but I didn't look that close.  I also saw at
>> least one patch that introduced a new function with no caller to test it.
>>
>> The idea is that a patch series leave a testable / functional kernel after
>> each patch in the series is applied sequentially.
>>
>> That is the only way git bisect can do its job.
>
> Very likely DRBD will not always be completely functional between
> any arbitrary two of these patches.
>
> The kernel as such will still be bisectable "just fine".

No.

That's not the way that kernel development works.

Besides which, that's not the way that "git bisect" works.

For example, say I have a driver bug that happens to be triggering
on my server which also happens to use GFS on DRBD. I try to
bisect the bug and it happens to pick a commit right in the middle
of this DRBD branch.

Suddenly DRBD is unusable or corrupting data or something, which
is unacceptable for an unrelated bisection of a driver bug.

So if you want these patches merged into the kernel, you need to
do them properly as per Documentation/SubmittingPatches.

Cheers,
Kyle Moffett