From: Oleg Nesterov <oleg@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Frank Rowand <frank.rowand@am.sony.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
users@kernel.org, hch <hch@infradead.org>,
"yong.zhang0" <yong.zhang0@gmail.com>,
scameron@beardog.cce.hp.com, Jens Axboe <jaxboe@fusionio.com>,
Thomas Gleixner <tglx@linutronix.de>,
"James E.J. Bottomley" <jejb@parisc-linux.org>
Subject: Re: [kernel.org users] [KORG] Panics on master backend
Date: Mon, 29 Aug 2011 16:38:55 +0200 [thread overview]
Message-ID: <20110829143855.GA29953@redhat.com> (raw)
In-Reply-To: <1314623216.2816.25.camel@twins>
On 08/29, Peter Zijlstra wrote:
>
> On Thu, 2011-08-25 at 15:54 +0200, Oleg Nesterov wrote:
> > > Isn't us holding ->pi_lock sufficient to stabilize task_cpu()? If its a
> > > running task the initial ->state check would have failed,
> >
> > Of course it is not TASK_RUNNING, but it can be running or not.
> >
> > > and thus its a
> > > proper wakeup when we get here and thus ->pi_lock is serializing things.
> >
> > I am not sure. If ->on_rq is true, we need rq->lock. Say, pull_task() can
> > change its cpu.
>
> If its !TASK_RUNNING but ->on_rq is true, it must be current, and
> pull_task() will never move current around.
You meant task_running() ? But it can be preempted in !TASK_RUNNING
state.
Oleg.
prev parent reply other threads:[~2011-08-29 14:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 18:09 [KORG] Panics on master backend J.H.
2011-08-23 19:52 ` [kernel.org users] " Peter Zijlstra
2011-08-23 21:32 ` James Bottomley
2011-08-24 9:59 ` Peter Zijlstra
2011-08-24 16:08 ` Oleg Nesterov
2011-08-25 10:24 ` Peter Zijlstra
2011-08-25 13:54 ` Oleg Nesterov
2011-08-26 6:01 ` Yong Zhang
2011-08-26 13:57 ` Oleg Nesterov
2011-08-29 2:29 ` Yong Zhang
2011-08-29 13:06 ` Peter Zijlstra
2011-08-29 14:38 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110829143855.GA29953@redhat.com \
--to=oleg@redhat.com \
--cc=frank.rowand@am.sony.com \
--cc=hch@infradead.org \
--cc=jaxboe@fusionio.com \
--cc=jejb@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=scameron@beardog.cce.hp.com \
--cc=tglx@linutronix.de \
--cc=users@kernel.org \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox