* [PATCH] gpiolib: add another might_sleep
@ 2011-02-17 21:18 Uwe Kleine-König
2011-08-29 19:01 ` Grant Likely
0 siblings, 1 reply; 4+ messages in thread
From: Uwe Kleine-König @ 2011-02-17 21:18 UTC (permalink / raw)
To: Grant Likely; +Cc: linux-kernel, kernel
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/gpio/gpiolib.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 5fc5e2d..2c9f814 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1207,6 +1207,7 @@ int gpio_request(unsigned gpio, const char *label)
if (chip->request) {
/* chip->request may sleep */
spin_unlock_irqrestore(&gpio_lock, flags);
+ might_sleep_if(chip->can_sleep);
status = chip->request(chip, gpio - chip->base);
spin_lock_irqsave(&gpio_lock, flags);
--
1.7.2.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] gpiolib: add another might_sleep
2011-02-17 21:18 [PATCH] gpiolib: add another might_sleep Uwe Kleine-König
@ 2011-08-29 19:01 ` Grant Likely
2012-09-13 8:36 ` Uwe Kleine-König
0 siblings, 1 reply; 4+ messages in thread
From: Grant Likely @ 2011-08-29 19:01 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-kernel, kernel
On Thu, Feb 17, 2011 at 10:18:53PM +0100, Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied, thanks.
g.
> ---
> drivers/gpio/gpiolib.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 5fc5e2d..2c9f814 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1207,6 +1207,7 @@ int gpio_request(unsigned gpio, const char *label)
> if (chip->request) {
> /* chip->request may sleep */
> spin_unlock_irqrestore(&gpio_lock, flags);
> + might_sleep_if(chip->can_sleep);
> status = chip->request(chip, gpio - chip->base);
> spin_lock_irqsave(&gpio_lock, flags);
>
> --
> 1.7.2.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gpiolib: add another might_sleep
2011-08-29 19:01 ` Grant Likely
@ 2012-09-13 8:36 ` Uwe Kleine-König
2012-09-16 21:55 ` Linus Walleij
0 siblings, 1 reply; 4+ messages in thread
From: Uwe Kleine-König @ 2012-09-13 8:36 UTC (permalink / raw)
To: Grant Likely, Linus Walleij; +Cc: linux-kernel, kernel
Hello,
On Mon, Aug 29, 2011 at 01:01:42PM -0600, Grant Likely wrote:
> On Thu, Feb 17, 2011 at 10:18:53PM +0100, Uwe Kleine-König wrote:
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Applied, thanks.
I cannot see it in Linus' tree?!
> > ---
> > drivers/gpio/gpiolib.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> > index 5fc5e2d..2c9f814 100644
> > --- a/drivers/gpio/gpiolib.c
> > +++ b/drivers/gpio/gpiolib.c
> > @@ -1207,6 +1207,7 @@ int gpio_request(unsigned gpio, const char *label)
> > if (chip->request) {
> > /* chip->request may sleep */
> > spin_unlock_irqrestore(&gpio_lock, flags);
> > + might_sleep_if(chip->can_sleep);
> > status = chip->request(chip, gpio - chip->base);
> > spin_lock_irqsave(&gpio_lock, flags);
> >
> > --
> > 1.7.2.3
> >
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gpiolib: add another might_sleep
2012-09-13 8:36 ` Uwe Kleine-König
@ 2012-09-16 21:55 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2012-09-16 21:55 UTC (permalink / raw)
To: Uwe Kleine-König, Grant Likely; +Cc: linux-kernel, kernel
On Thu, Sep 13, 2012 at 10:36 AM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> Hello,
>
> On Mon, Aug 29, 2011 at 01:01:42PM -0600, Grant Likely wrote:
>> On Thu, Feb 17, 2011 at 10:18:53PM +0100, Uwe Kleine-König wrote:
>> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>
>> Applied, thanks.
>
> I cannot see it in Linus' tree?!
It's probably because it's in Grant's tree! :-)
Grant, are you up to speed with GPIO again? Shall I send you a pull
request for the stuff I've queued up?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-16 21:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-17 21:18 [PATCH] gpiolib: add another might_sleep Uwe Kleine-König
2011-08-29 19:01 ` Grant Likely
2012-09-13 8:36 ` Uwe Kleine-König
2012-09-16 21:55 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).